Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve text according to feedback #3

Merged
merged 3 commits into from
Nov 24, 2022
+7 −3
Merged

Improve text according to feedback #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
711b937
Improve text according to feedback
gastaldi Nov 24, 2022
5e0cc7f
Improve .gitignore
gastaldi Nov 24, 2022
1c2831b
Remove Paul from notification email
gastaldi Nov 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,7 @@ hs_err_pid*
# JIRA Lint specific files
*-test.xml
emails.html

# IDE files
*.iml
.idea
2 changes: 1 addition & 1 deletion quarkus.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
{
"OpenOrVersionedNotDoneIssue": {
"jql": "project = QUARKUS AND (resolution != 'Done') AND (status not in (Closed) or fixVersion is not EMPTY)",
"description": "Duplicate issues should be in the 'Closed' status and not be assigned to a FixVersion. This ensures that they don't clutter up reports. Please fix this be ensuring the issue is in the 'Closed' status and that the 'Fix Version/s' field is empty"
"description": "Open Issues with a resolution different than 'Done' should be in the 'Closed' status and not be assigned to a FixVersion. This ensures that they don't clutter up reports. Please fix this be ensuring the issue is in the 'Closed' status and that the 'Fix Version/s' field is empty"
}
},
{
Expand Down
4 changes: 2 additions & 2 deletions run.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ else if (getFirstComponentLead(issue) != null) { // Try component lead next
}
else //Fallback to JIRA Lint process maintainer
{
jiraUser = new JiraUser("Paul Robinson", "[email protected]");
jiraUser = new JiraUser("RHBQ Release Coordinator", EMAIL_FROM);
}

ReportResult reportResult = new ReportResult(reportItemID, issue.getSummary(), reportItem.getDescription(), new URL("https://issues.redhat.com/browse/" + issue.getKey()), issue.getKey(), jiraUser);
Expand Down Expand Up @@ -308,7 +308,7 @@ public String createEmailBody(JiraUser jiraUser, List<ReportResult> reportResult
body += "</p>";
body += "<p>If you are confused, or think this email has been sent in error, hit reply to let me know.</p>";
body += "<p>Thanks,</p>";
body += "<p>Paul (via the JIRA Lint tool)</p>";
body += "<p>RHBQ Release Coordinator (via the JIRA Lint tool)</p>";

return body;
}
Expand Down