Harder, better, faster, stronger

[daxxog]

Harder, better, faster, stronger

[proper version, merge this]

What is included in this pull request?

• make.js file for easy building via nodejs
• Over 2x speed increase for grid rendering!
  • 50 items with old script took took 619ms to render on my machine
  • 50 items with new script takes 255ms to render on my machine
• Selector caching system. Other people can use this to speed up the grid even more!

Selector cache example

old code

$('th:eq(' + n + ')', g.hDiv);

new code

g.cacheSel('th:eq(' + n + ')', 'hDiv');

[NaomiN]

Hi,

I just downloaded the latest suggested version of both flexigrid.css and
flexigrid.js (and packed versions). I see that my Add, Edit, Delete buttons
no longer have pictures - what should I do to make them show their pictures
again?

Also, I had the following code to allow double clicking on the selected row
to invoke Edit functionality:

function bindDblClick()
{
$('#flexClients tr').dblclick(function () {
edit('Edit');
});
}

This also doesn't work anymore. Finally, all my dialogs now look very
weird. They look like they are now transparent and the grid bleeds through
them. Also, the close button of the dialogs doesn't look like it used (the
x at the top, but the button with close instead). I am relatively new to
jQuery and I had my project working Ok about 2+ months ago. Today I tried
running it again and got all these problems.

I attached my js file that defines dialogs and flexigrid - may be you can
help me.

Thanks a lot again.

On Tue, Mar 5, 2013 at 8:36 PM, David Volm [email protected] wrote:

Harder, better, faster, stronger

[proper version, merge this]

What is included in this pull request?

• make.js file for easy building via nodejs
• Over 2x speed increase for grid rendering!
  • 50 items with old script took took 619ms to render on my machine
  • 50 items with new script takes 255ms to render on my machine
    • Selector caching system. Other people can use this to speed up
      the grid even more!

Selector cache example

old code

$('th:eq(' + n + ')', g.hDiv);

new code

g.cacheSel('th:eq(' + n + ')', 'hDiv');

---

You can merge this Pull Request by running

git pull https://github.com/daxxog/Flexigrid pull2

Or view, comment on, or merge it at:

#78
Commit Summary

• Harder, better, faster, stronger
• My changes to the JavaScript source.
• Cleaned up a bit.

File Changes

• A .gitignorehttps://github.com/Harder, better, faster, stronger #78/files#diff-0(1)
• M css/flexigrid.csshttps://github.com/Harder, better, faster, stronger #78/files#diff-1(1182)
• M css/flexigrid.pack.csshttps://github.com/Harder, better, faster, stronger #78/files#diff-2(104)
• A demo/speed-test-old.htmlhttps://github.com/Harder, better, faster, stronger #78/files#diff-3(136)
• A demo/speed-test.htmlhttps://github.com/Harder, better, faster, stronger #78/files#diff-4(136)
• A js/flexigrid.hhttps://github.com/Harder, better, faster, stronger #78/files#diff-5(8)
• M js/flexigrid.jshttps://github.com/Harder, better, faster, stronger #78/files#diff-6(83)
• M js/flexigrid.pack.jshttps://github.com/Harder, better, faster, stronger #78/files#diff-7(9)
• A make.jshttps://github.com/Harder, better, faster, stronger #78/files#diff-8(120)

Patch Links:

• https://github.com/paulopmx/Flexigrid/pull/78.patch
• https://github.com/paulopmx/Flexigrid/pull/78.diff

[NaomiN]

Who is RS (that's the initials I see for the version I downloaded) and
given this code

if (btn.bimage) // if bimage defined, use its string as an image url for
this button style (RS)
$('span',btnDiv).css( 'background', 'url('+btn.bimage+') no-repeat center
left' );
$('span',btnDiv).css( 'paddingLeft', 20 );

if (btn.tooltip) // add title if exists (RS)
$('span',btnDiv)[0].title = btn.tooltip;

and the following structure in my MVC application

Content\Themes\FlexiGrid\Images\add.png

what should I put for bimage property? Also, before the latest update the
images for buttons showed up automatically - can we somehow specify default
images on the class level?

Thanks again.

On Thu, Mar 28, 2013 at 7:47 PM, Naomi Nosonovsky [email protected]:

Hi,

I just downloaded the latest suggested version of both flexigrid.css and
flexigrid.js (and packed versions). I see that my Add, Edit, Delete buttons
no longer have pictures - what should I do to make them show their pictures
again?

Also, I had the following code to allow double clicking on the selected
row to invoke Edit functionality:

function bindDblClick()
{
$('#flexClients tr').dblclick(function () {
edit('Edit');
});
}

This also doesn't work anymore. Finally, all my dialogs now look very
weird. They look like they are now transparent and the grid bleeds through
them. Also, the close button of the dialogs doesn't look like it used (the
x at the top, but the button with close instead). I am relatively new to
jQuery and I had my project working Ok about 2+ months ago. Today I tried
running it again and got all these problems.

I attached my js file that defines dialogs and flexigrid - may be you can
help me.

Thanks a lot again.

On Tue, Mar 5, 2013 at 8:36 PM, David Volm [email protected]:

Harder, better, faster, stronger

[proper version, merge this]

What is included in this pull request?

• make.js file for easy building via nodejs
• Over 2x speed increase for grid rendering!
  • 50 items with old script took took 619ms to render on my
    machine
  • 50 items with new script takes 255ms to render on my machine
    • Selector caching system. Other people can use this to speed up
      the grid even more!

Selector cache example

old code

$('th:eq(' + n + ')', g.hDiv);

new code

g.cacheSel('th:eq(' + n + ')', 'hDiv');

---

You can merge this Pull Request by running

git pull https://github.com/daxxog/Flexigrid pull2

Or view, comment on, or merge it at:

#78
Commit Summary

• Harder, better, faster, stronger
• My changes to the JavaScript source.
• Cleaned up a bit.

File Changes

• A .gitignorehttps://github.com/Harder, better, faster, stronger #78/files#diff-0(1)
• M css/flexigrid.csshttps://github.com/Harder, better, faster, stronger #78/files#diff-1(1182)
• M css/flexigrid.pack.csshttps://github.com/Harder, better, faster, stronger #78/files#diff-2(104)
• A demo/speed-test-old.htmlhttps://github.com/Harder, better, faster, stronger #78/files#diff-3(136)
• A demo/speed-test.htmlhttps://github.com/Harder, better, faster, stronger #78/files#diff-4(136)
• A js/flexigrid.hhttps://github.com/Harder, better, faster, stronger #78/files#diff-5(8)
• M js/flexigrid.jshttps://github.com/Harder, better, faster, stronger #78/files#diff-6(83)
• M js/flexigrid.pack.jshttps://github.com/Harder, better, faster, stronger #78/files#diff-7(9)
• A make.jshttps://github.com/Harder, better, faster, stronger #78/files#diff-8(120)

Patch Links:

• https://github.com/paulopmx/Flexigrid/pull/78.patch
• https://github.com/paulopmx/Flexigrid/pull/78.diff