Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filter pattern not being applied to files inside symlink subdirectories of the watched path #1307

Closed

Conversation

samuelneff
Copy link

This PR resolves issue #967 and applies the pattern filter to files nested inside symlinks.

No change in expected behavior or usage. New passing test added.

@samuelneff
Copy link
Author

I'll address those issues, assuming they're real issues (lint at least probably is). 👍

@samuelneff
Copy link
Author

@paulmillr It looks like none of the errors are actually related to my PR but are existing issues. This particular one is with DTS Lint and a missing function.

@paulmillr
Copy link
Owner

As i’ve mentioned, we can’t really merge new code unless we fix the old tests.

Otherwise some stuff could get broken and we wouldn’t even know.

Thanks for the pr.

@samuelneff
Copy link
Author

Thanks for the update. I missed that specific message about the tests. I'll work on those next. 👍

@paulmillr paulmillr closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants