Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI config #1199

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Update CI config #1199

merged 1 commit into from
Feb 4, 2022

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Jan 27, 2022

  • specify FORCE_COLOR: 2 for colored output
  • update actions/checkout to v2
  • update actions/setup-node to v2

@paulmillr I see CI is still flaky :/

@XhmikosR XhmikosR marked this pull request as ready for review January 27, 2022 06:25
@paulmillr
Copy link
Owner

@XhmikosR what's the difference from v1?

@XhmikosR
Copy link
Contributor Author

They don't have a clear changelog but there have been many fixes and new features:

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Jan 27, 2022

Should I add Node.js 16 while at it? I see there's an unhandled promise rejection which would be an error in Node.js 16 anyway...

EDIT: also, if you want to change the matrix to only run one combo for non Ubuntu OS'es let me know.

@XhmikosR
Copy link
Contributor Author

Ah, I just saw you have a v4 branch too. Happy to make these tweaks there too later.

@paulmillr
Copy link
Owner

Use this:

        with:
          node-version: ${{ matrix.node }}

* add `workflow_dispatch`
* specify `FORCE_COLOR: 2` for colored output
* update `actions/checkout` to v2
* update `actions/setup-node` to v2
* add Node.js 16
* reduce CI matrix
@XhmikosR
Copy link
Contributor Author

Not sure what you mean?

@paulmillr paulmillr merged commit b059841 into paulmillr:master Feb 4, 2022
@XhmikosR XhmikosR deleted the patch-1 branch February 4, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants