Merge pull request #1288 from JLHwung/fix-ready-count

fix readyCount logic
paulmillr · Sep 6, 2023 · 399647e · 399647e
2 parents 08318d6 + f022fe7
commit 399647e
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -441,7 +441,7 @@ add(paths_, _origAdd, _internal) {
 
   if (this.options.useFsEvents && this._fsEventsHandler) {
     if (!this._readyCount) this._readyCount = paths.length;
-    if (this.options.persistent) this._readyCount *= 2;
+    if (this.options.persistent) this._readyCount += paths.length;
     paths.forEach((path) => this._fsEventsHandler._addToFsEvents(path));
   } else {
     if (!this._readyCount) this._readyCount = 0;

diff --git a/test.js b/test.js
@@ -549,6 +549,21 @@ const runTests = (baseopts) => {
     });
   });
   describe('watch individual files', () => {
+    it('should emit `ready` when three files were added', async () => {
+      const readySpy = sinon.spy(function readySpy(){});
+      const watcher = chokidar_watch().on(EV_READY, readySpy);
+      const path1 = getFixturePath('add1.txt');
+      const path2 = getFixturePath('add2.txt');
+      const path3 = getFixturePath('add3.txt');
+
+      watcher.add(path1);
+      watcher.add(path2);
+      watcher.add(path3);
+
+      await waitForWatcher(watcher);
+      // callCount is 1 on macOS, 4 on Ubuntu
+      readySpy.callCount.should.be.greaterThanOrEqual(1);
+    });
     it('should detect changes', async () => {
       const testPath = getFixturePath('change.txt');
       const watcher = chokidar_watch(testPath, options);