correctly unmarshal elements with a type tag #53
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as described in #51 the "quick hack" to find the type does not work if the the element has
"tags":{"type":"route"}
like relations have.This PR finds the tag using an unmarshal, it does impact performance.
I was able to get it down to +7% speed but much more memory using
json.Decoder.Token
. I opted for the simpler approach as it allowed the plugging in of "customer unmarshallers".If performance is a concern consider using jsoniter or similar like