Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix H264RtpDepacketizer to handle empty payload RTP packet #1140

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Fix H264RtpDepacketizer to handle empty payload RTP packet #1140

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1da765
Add empty payload packet handling to H264DEpacketizer
sile Mar 27, 2024
c5c80b8
Add padding handling
sile Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/h264rtpdepacketizer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,17 @@ message_vector H264RtpDepacketizer::buildFrames(message_vector::iterator begin,
auto pktParsed = reinterpret_cast<const rtc::RtpHeader *>(pkt->data());
auto headerSize =
sizeof(rtc::RtpHeader) + pktParsed->csrcCount() + pktParsed->getExtensionHeaderSize();
auto paddingSize = 0;

if (pktParsed->padding()) {
paddingSize = std::to_integer<uint8_t>(pkt->at(pkt->size() - 1));
}

if (pkt->size() == headerSize + paddingSize) {
PLOG_VERBOSE << "H.264 RTP packet has empty payload";
continue;
}

auto nalUnitHeader = NalUnitHeader{std::to_integer<uint8_t>(pkt->at(headerSize))};

if (fua_buffer.size() != 0 || nalUnitHeader.unitType() == naluTypeFUA) {
Expand Down
Loading