Small optimalisation.

paulissoft · Jul 4, 2024 · e3cc54c · e3cc54c
1 parent 21d406b
commit e3cc54c
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 11 deletions.
diff --git a/jdbc/smart-pool-data-source/src/main/java/com/paulissoft/pato/jdbc/SmartPoolDataSource.java b/jdbc/smart-pool-data-source/src/main/java/com/paulissoft/pato/jdbc/SmartPoolDataSource.java
@@ -361,20 +361,27 @@ public final Connection getConnection() throws SQLException {
                                                               state.toString()));
             }
 
+            // minimize accessing volatile variables by shadowing them
+            final T poolDataSourceOverflow = this.poolDataSourceOverflow;
+
             Connection conn;
 
             // Try to avoid connection timeout errors.
-            // When the pool data source is full with idle connections, use immediately the dynamic pool (and try the fixed one later on).
-            if (hasOverflow() && poolDataSource.getIdleConnections() == 0 && poolDataSource.getTotalConnections() == poolDataSource.getMaxPoolSize()) {
+            // When the fixed pool data source is full with idle connections,
+            // use immediately the dynamic pool (and try the fixed one later on).
+            if (poolDataSourceOverflow != null &&
+                poolDataSource.getIdleConnections() == 0 &&
+                poolDataSource.getTotalConnections() == poolDataSource.getMaxPoolSize()) {
                 useOverflow = true;
             }
 
             try {
-                conn = getConnection(useOverflow);
+                conn = getConnection(useOverflow, poolDataSource, poolDataSourceOverflow);
             } catch (Exception ex) {
                 // switch pools (just once) when the connection fails due to no idle connections 
-                if ((useOverflow || hasOverflow()) && getConnectionFailsDueToNoIdleConnections(ex)) {
-                    conn = getConnection(!useOverflow);
+                if ((useOverflow || poolDataSourceOverflow != null) &&
+                    getConnectionFailsDueToNoIdleConnections(ex)) {
+                    conn = getConnection(!useOverflow, poolDataSource, poolDataSourceOverflow);
                 } else {
                     throw ex;
                 }
@@ -386,16 +393,18 @@ public final Connection getConnection() throws SQLException {
         }
     }
 
-    protected Connection getConnection(final boolean useOverflow) throws SQLException {
-        log.trace(">getConnection({})", useOverflow);
+    protected Connection getConnection(final boolean useOverflow,
+                                       final T poolDataSource,
+                                       final T poolDataSourceOverflow) throws SQLException {
+        log.trace(">getConnection({}, ...)", useOverflow);
 
-        final T pds = useOverflow ? getPoolDataSourceOverflow() : getPoolDataSource();
+        final T pds = useOverflow ? poolDataSourceOverflow : poolDataSource;
         final PoolDataSourceStatistics pdsStatistics = useOverflow ? getPoolDataSourceStatisticsOverflow() : getPoolDataSourceStatistics();
 
         try {
             return getConnection(pds, pdsStatistics, hasShownConfig[useOverflow ? 1 : 0]);
         } finally {
-            log.trace("<getConnection({})", useOverflow);
+            log.trace("<getConnection({}, ...)", useOverflow);
         }
     }
 

diff --git a/...rt-pool-data-source/src/main/java/com/paulissoft/pato/jdbc/SmartPoolDataSourceOracle.java b/...rt-pool-data-source/src/main/java/com/paulissoft/pato/jdbc/SmartPoolDataSourceOracle.java
@@ -244,8 +244,11 @@ protected boolean getConnectionFailsDueToNoIdleConnections(final Exception ex) {
         return (ex instanceof SQLException) && ex.getMessage().matches(REX_CONNECTION_TIMEOUT);
     }
 
-    protected Connection getConnection(final boolean useOverflow) throws SQLException {
-        final Connection conn = super.getConnection(useOverflow);
+    @Override
+    protected Connection getConnection(final boolean useOverflow,
+                                       final SimplePoolDataSourceOracle poolDataSource,
+                                       final SimplePoolDataSourceOracle poolDataSourceOverflow) throws SQLException {
+        final Connection conn = super.getConnection(useOverflow, poolDataSource, poolDataSourceOverflow);
 
         if (useOverflow) {
             // The setInvalid method of the ValidConnection interface