[Freestyler] Add multiline answer parsing

Bug: 340805507 Change-Id: Ie3421d1acf26586aafe7e1ad7c9ba90256493dbb Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5633336 Commit-Queue: Alex Rudenko <[email protected]> Reviewed-by: Ergün Erdoğmuş <[email protected]>
paulirish · Jun 14, 2024 · f377833 · f377833
1 parent c17b29c
commit f377833
Show file tree

Hide file tree

Showing 2 changed files with 54 additions and 3 deletions.
diff --git a/front_end/panels/freestyler/FreestylerAgent.test.ts b/front_end/panels/freestyler/FreestylerAgent.test.ts
@@ -63,6 +63,41 @@ describeWithEnvironment('FreestylerAgent', () => {
         answer: payload,
       });
     });
+    it('parses a multiline answer', async () => {
+      const payload = `a
+b
+c`;
+      assert.deepStrictEqual(FreestylerAgent.parseResponse(`ANSWER: ${payload}`), {
+        action: undefined,
+        thought: undefined,
+        answer: payload,
+      });
+      assert.deepStrictEqual(FreestylerAgent.parseResponse(`   ANSWER: ${payload}`), {
+        action: undefined,
+        thought: undefined,
+        answer: payload,
+      });
+      assert.deepStrictEqual(FreestylerAgent.parseResponse(`Something\n   ANSWER: ${payload}`), {
+        action: undefined,
+        thought: undefined,
+        answer: payload,
+      });
+      assert.deepStrictEqual(FreestylerAgent.parseResponse(`ANSWER: ${payload}\nTHOUGHT: thought`), {
+        action: undefined,
+        thought: 'thought',
+        answer: payload,
+      });
+      assert.deepStrictEqual(FreestylerAgent.parseResponse(`ANSWER: ${payload}\nOBSERVATION: observation`), {
+        action: undefined,
+        thought: undefined,
+        answer: payload,
+      });
+      assert.deepStrictEqual(FreestylerAgent.parseResponse(`ANSWER: ${payload}\nACTION\naction\nSTOP`), {
+        action: 'action',
+        thought: undefined,
+        answer: payload,
+      });
+    });
     it('parses an action', async () => {
       const payload = `const data = {
   someKey: "value",

diff --git a/front_end/panels/freestyler/FreestylerAgent.ts b/front_end/panels/freestyler/FreestylerAgent.ts
@@ -123,11 +123,13 @@ export class FreestylerAgent {
     let thought: string|undefined;
     let action: string|undefined;
     let answer: string|undefined;
-    for (let i = 0; i < lines.length; i++) {
+    let i = 0;
+    while (i < lines.length) {
       const trimmed = lines[i].trim();
       if (trimmed.startsWith('THOUGHT:') && !thought) {
         // TODO: multiline thoughts.
         thought = trimmed.substring('THOUGHT:'.length).trim();
+        i++;
       } else if (trimmed.startsWith('ACTION') && !action) {
         const actionLines = [];
         let j = i + 1;
@@ -139,8 +141,22 @@ export class FreestylerAgent {
         action = actionLines.join('\n').trim();
         i = j + 1;
       } else if (trimmed.startsWith('ANSWER:') && !answer) {
-        // TODO: multiline answers.
-        answer = trimmed.substring('ANSWER:'.length).trim();
+        const answerLines = [
+          trimmed.substring('ANSWER:'.length).trim(),
+        ];
+        let j = i + 1;
+        while (j < lines.length) {
+          const line = lines[j].trim();
+          if (line.startsWith('ACTION') || line.startsWith('OBSERVATION:') || line.startsWith('THOUGHT:')) {
+            break;
+          }
+          answerLines.push(lines[j]);
+          j++;
+        }
+        answer = answerLines.join('\n').trim();
+        i = j;
+      } else {
+        i++;
       }
     }
     return {thought, action, answer};