Suggested fix for winstonjs#213: More than 10 containers triggers Eve…

…ntEmitter memory leak warning
paulhroth · Jun 3, 2015 · 5999c70 · 5999c70
1 parent 445da9c
commit 5999c70
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/lib/winston/logger.js b/lib/winston/logger.js
@@ -460,8 +460,8 @@ Logger.prototype.add = function (transport, options, created) {
   //
   // Listen for the `error` event on the new Transport
   //
+  instance._onError = this._onError.bind(this, instance)
   if (! created) {
-    instance._onError = this._onError.bind(this, instance)
     instance.on('error', instance._onError);
   }
 
@@ -531,7 +531,9 @@ Logger.prototype.remove = function (transport) {
     instance.close();
   }
 
-  instance.removeListener('error', instance._onError);
+  if (instance._onError) {
+    instance.removeListener('error', instance._onError);
+  }
   return this;
 };