Skip to content

Commit

Permalink
fix(core): core constructs fail with `Error: Cannot find module '../d…
Browse files Browse the repository at this point in the history
…ist/core/<file>.generated'` (aws#28467)

aws#28251 added new files to `aws-cdk-lib/core/lib/dist/core` but this path was excluded from the npm package, causing the above error.

This fix includes the generated file into the package.

Closes aws#28465

Manually tested with a locally build package that includes the fix.
<img width="1449" alt="image" src="https://github.com/aws/aws-cdk/assets/379814/11714c41-edea-403e-9b64-454ba9768c08">

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
mrgrain authored and paulhcsun committed Jan 5, 2024
1 parent 093d9d0 commit 1788975
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion packages/aws-cdk-lib/.npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ coverage
build-tools
dist
!custom-resource-handlers/dist/
!core/lib/dist/
scripts
.LAST_BUILD
.LAST_PACKAGE
Expand All @@ -30,9 +31,11 @@ tsconfig.json
# exclude cdk artifacts
**/cdk.out
junit.xml

!*.lit.ts

# exclude additional documention
core/adr/

# keep class map for cloudformation-include
!cloudformation-include/cfn-types-2-classes.json

Expand Down

0 comments on commit 1788975

Please sign in to comment.