Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the version in the POM file before building the package #194

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

mardukbp
Copy link
Contributor

The project version in the current POM file contains a placeholder that is replaced during Maven's execution. However, Maven repositories read the version from the POM file.

This PR reads the version from package.json and updates the version in the POM file. Afterwards the build process and the deployment can proceed as usual.

The instructions for deploying, found in RELEASE.md, were correspondingly updated.

…tead of using a placeholder that is replaced at runtime.
Copy link
Owner

@paulfitz paulfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks like an improvement. Steps 1 and 2 work, will try 3 once landed.

@paulfitz paulfitz merged commit 140a1af into paulfitz:master Sep 15, 2023
@paulfitz
Copy link
Owner

I tried another release. Needed to mint a new version, there is a github release that happens too that complicates things (if there were a way to disable that it would be great).

@mardukbp
Copy link
Contributor Author

A-wesome! Thanks a lot @paulfitz! I just built a small project with it.

Yes, the GitHub releases can be avoided. Take a look at the documentation of JReleaser. Instead of full-release I think you would want to execute deploy and upload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants