-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add updated columns summary #167
base: master
Are you sure you want to change the base?
Conversation
To possibly have more extensive report on summary for changes per column
Thanks @hasnat. The test failure seems to be mostly due to a haxe change, where the return type of the main method is constrained to be void. I expect that could be easy to fix, just by calling Is there a test case you can think of to show the expected behavior of this change? You can find some existing checks on |
thanks @paulfitz for the directions on test cases. I can try adding a couple along with haxe main change. my aim is to have summary include following details (satisfies my usecase) not sure if this should be complete with inserts/deletes info, and which way to nest if we're completing set ? |
hi @paulfitz initial aim of mine was to capture diff/diff types counts against columns Ideal diff am after will visually provide data as such. (possibly meta info in squeezed in cols schema... see meta below) code in this PR is far from optimal and not intendented for merge yet. However I'd like to discuss further if this is something way off daff or we can steer this draft to right path?
meta (column_units_updates) from start of draft now looks like this
|
To possibly have more extensive report on summary for changes per column.
TODO: update map to <String,Int> to capture column names instead of index
note: not sure why tests are failing.
note2: possibly this MR is not the way, and some other way is preferred.