Force using correct mixin of MockFactory in async/sync tests #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nimatrueway
changed the title
It is helpful to prevent mistakenly mixing synchronous tests with asynchronous mock-factory and vice versa
|
very cool, thanks for this PR, could you please confirm that you are happy with this:
|
Gladly done! I just added the checklist to PR's description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Fixes
Fixes #371
Purpose
As been mentioned in README.md the trait
AsyncMockFactoryshould be used withAsync*Specclasses otherwise tests will be ignored silently.This PR enforces this idea further, as users will receive feedback at compile time to help.