Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure there is no uninitialized variables in AsyncMockFactoryBase #227

Merged
merged 1 commit into from
May 6, 2018

Conversation

by-dam
Copy link
Contributor

@by-dam by-dam commented May 4, 2018

This avoids scala.UninitializedFieldError when run on scala 2.12
with -Xcheckinit compiler flag.

Pull Request Checklist

  • I agree to licence my contributions under the MIT licence
  • I have added copyright headers to new files (no new files)
  • I have added tests for any changed functionality (added compiler flag to build.sbt)

Fixes

Fixes #226

Purpose

Call initializeExpectations in AsyncMockFactoryBase constructor to avoid uninitialized variables.

This avoids `scala.UninitializedFieldError` when run on scala 2.12
with `-Xcheckinit` compiler flag.
@barkhorn
Copy link
Collaborator

barkhorn commented May 6, 2018

thanks!

@barkhorn barkhorn added this to the v4.2.0 milestone May 6, 2018
@barkhorn barkhorn merged commit f20cad7 into paulbutcher:master May 6, 2018
@barkhorn
Copy link
Collaborator

barkhorn commented May 6, 2018

you should be able to use the snapshot build on sonatype to test with your code until i release 4.2 to maven central

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants