Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BasicAsyncTest for issue #215 #217

Merged
merged 1 commit into from
Feb 17, 2018
Merged

Conversation

lj-ditrapani
Copy link
Contributor

Pull Request Checklist

  • I agree to licence my contributions under the MIT licence
  • I have added copyright headers to new files
  • I have added tests for any changed functionality

Purpose

Adds a test to cover issue #215

References

Issue #215

@barkhorn
Copy link
Collaborator

barkhorn commented Feb 8, 2018

Am I right that this test fails on 4.0.0, but passes on 4.1.0-SNAPSHOT, proving that #215 is not an issue anymore?

@barkhorn barkhorn added this to the v4.1.0 milestone Feb 8, 2018
@lj-ditrapani
Copy link
Contributor Author

Yes, that is right. The test is just to prevent a future regression.

@barkhorn barkhorn merged commit 2a1fad4 into paulbutcher:master Feb 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants