This repository has been archived by the owner on Apr 11, 2018. It is now read-only.
Allow set tag to use bracket notation for object properties #388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current version of Swig, if you're using the
set
tag to assign a value to an object's property, you can't use bracket notation for the object property. For example, if you've already set the local variablesfoo = {}
andbar = 'bar'
, any of the following will cause Swig to complain about an unexpected assignment:This pull request makes all of those examples work as you'd expect. It still behaves correctly if a quoted property name includes an assignment operator.
If you have any feedback on this pull request, I'd be happy to amend it.
(P.S. Thanks for creating such an excellent template engine!)