This repository has been archived by the owner on Apr 11, 2018. It is now read-only.
Update dateformatter.js #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected date calculation for day of week
|
Please ensure tests are passing. |
This matches PHP:
echo date('N', strtotime('2011-09-06T16:05:02.000Z'))."\n";
echo date('N', strtotime('2011-09-04T16:05:02.000Z'))."\n";
|
Tests were failing but were wrong. Fixed test and added another for Sunday. See php code in commit message as I used that to check. |
paularmstrong
added a commit
that referenced
this pull request
Jan 10, 2014
Fix date formatting for 'N' (ISO-8601 numeric representation of the day of the week)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected date calculation for day of week.
it looks like getDay() returns 0-6 but that 0 is sunday. So no modifier is necessary for the other weekdays - we just need sunday to become 7.
Both of these print 7 right now