This repository has been archived by the owner on Apr 11, 2018. It is now read-only.
bug for nested variable not usable in for tag
#232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to validate the property "name" of variable 'operand2', because the variable name will be instead as '__loopIter'. The validation cause syntax like '<% for item in pord.items %>' throw an error, which are availiable in fact.
|
Can you write a unit test to assert this behavior? https://github.com/paularmstrong/swig/blob/master/CONTRIBUTING.md#checklist |
paularmstrong
added a commit
that referenced
this pull request
Jun 9, 2013
|
This has been merged. |
|
I'm sorry I ignored the previous comments, you are a conscientious maintainer. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to validate the property
nameof variableoperand2, because the variable name will be instead as__loopIter.The validation cause syntax like
<% for item in pord.items %>throw an error, which are availiable in fact.