This repository has been archived by the owner on Apr 11, 2018. It is now read-only.
Refactor Convert All Tests to Mocha + expect.js #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just used to this now... sorry.
paularmstrong
added a commit
that referenced
this pull request
Oct 27, 2012
Refactor Convert All Tests to Mocha + expect.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry to do this, but we get a couple major benefits out of this:
make coveragewill build a coverage report, showing how much (relative) test coverage we have. Currently 94%!make test-browserwill now build for the browser and run the tests through phantomjs (which means they also build on travis-ci)Also, I switched to 2-space indenting because we use 2-space at work and sublimetext doesn't seem to want to manage switching between different indenting very well.