fix(DagreGroupLayout): Keep node order when groups are collapsed #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordrip
approved these changes
Aug 8, 2024
jenny-s51
approved these changes
Aug 8, 2024
|
🎉 This PR is included in version 5.4.0-prerelease.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
jeff-phillips-18
added a commit
to jeff-phillips-18/react-topology
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #230
Description
On layout, add the nodes to the Dagre layout in the same order given to the graph. This maintains the ordering in the graph when groups are collapsed/expanded.
Type of change
/cc @lordrip