Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce node details when at low scale #125

Merged

Conversation

jeff-phillips-18
Copy link
Member

What

Closes #124

Description

Update to get details level directly from the graph rather that using the useDetailsLevel hook so that the scale level is observed and nodes redraw on scale change.

Type of change

  • Bugfix

Copy link
Collaborator

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nodes redraw on scale change, status background is visible at low scale

Copy link
Collaborator

@leandroberetta leandroberetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeff-phillips-18 jeff-phillips-18 merged commit 4f416c8 into patternfly:main Dec 13, 2023
7 checks passed
@jeff-phillips-18 jeff-phillips-18 deleted the node-details-scale branch December 13, 2023 12:56
Copy link

🎉 This PR is included in version 5.2.0-prerelease.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nodes in demo app no longer scale down to show status background at low scale.
3 participants