Topology: Convex algorithm for nodes of different sizes looks weird #14
Milestone
Comments
jenny-s51
added a commit
that referenced
this issue
Nov 13, 2024
Add demo option to hide kebab context menus (#14) add condition to contextSpace to fix label size add check to TaskPill remove hideContextMenuKebab from withContextMenuProps add hideContextMenuKebab to NodeLabelProps to fix error
jeff-phillips-18
pushed a commit
to jeff-phillips-18/react-topology
that referenced
this issue
Dec 4, 2024
…ly#250) Add demo option to hide kebab context menus (patternfly#14) add condition to contextSpace to fix label size add check to TaskPill remove hideContextMenuKebab from withContextMenuProps add hideContextMenuKebab to NodeLabelProps to fix error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the issue. What is the expected and unexpected behavior?
The hull algorithm used to draw the outline of or groups on topology was built to support nodes of the same size. It identifies the point of the node and then adds padding. If all nodes are the same size, the tangent lines between nodes always intersect the circle outline of the nodes where a 90 degree angle could be formed that goes to the center of the node.
This however doesn't work with nodes of different sizes are shown here:
Another example:
Please provide the steps to reproduce. Feel free to link CodeSandbox or another tool.
n/a
Is this a bug or enhancement? If this issue is a bug, is this issue blocking you or is there a work-around?
More a bug, but also an enhancement 😏
What is your product and what release version are you targeting?
OpenShift Developer Console, this is a known issue since 4.6, and was reported initially as ODC-2071, but since the code was extracted into @patternfly/react-topology we believe we should follow up this issue here.
/cc @jerolimov
The text was updated successfully, but these errors were encountered: