Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for tooltips on disabled dropdown items (aria-disabled variation) #5826

Closed
mcoker opened this issue May 24, 2021 · 2 comments · Fixed by #6038
Closed

Support for tooltips on disabled dropdown items (aria-disabled variation) #5826

mcoker opened this issue May 24, 2021 · 2 comments · Fixed by #6038
Assignees
@nicolethoen
Labels
A11y
Milestone
2021.10

Comments

@mcoker
Copy link
Contributor

mcoker commented May 24, 2021

From a discussion in this issue - #5127

We added support for a .pf-m-aria-disabled variation on dropdown items to support adding tooltips on disabled items

patternfly/patternfly#4072

cc @jschuler @mcarrano
@mcoker
Copy link
Contributor Author

mcoker commented May 24, 2021

@tlabaj is this the same issue as #4581?

@tlabaj tlabaj added this to the 2021.08 milestone Jun 2, 2021
@tlabaj
Copy link
Contributor

tlabaj commented Jun 2, 2021

@mcoker. I believe so. I will close the other issues since this one has already been prioritized.

@tlabaj tlabaj added the A11y label Jun 2, 2021
@mcarrano mcarrano modified the milestones: 2021.08, 2021.10 Jun 25, 2021
@nicolethoen nicolethoen mentioned this issue Jul 15, 2021
Merged
@cben cben mentioned this issue Aug 2, 2021
Closed
@cben cben mentioned this issue Aug 9, 2021
Closed
KKoukiou added a commit to KKoukiou/cockpit-machines that referenced this issue Oct 9, 2024
@KKoukiou
Fix disabled VM action dropdown item tooltip
7197f8c 
When using `isDisabled` property in Buttons/Dropdowns/etc, their tooltips
are not getting triggered.
We need to use `isAriaDisabled` instead of `isDisabled` in this case.

See more info: patternfly/patternfly-react#5826
@KKoukiou KKoukiou mentioned this issue Oct 9, 2024
Merged
martinpitt pushed a commit to cockpit-project/cockpit-machines that referenced this issue Oct 9, 2024
@KKoukiou @martinpitt
Fix disabled VM action dropdown item tooltip
1daeb37 
When using `isDisabled` property in Buttons/Dropdowns/etc, their tooltips
are not getting triggered.
We need to use `isAriaDisabled` instead of `isDisabled` in this case.

See more info: patternfly/patternfly-react#5826
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolethoen nicolethoen

Labels
A11y
Projects
None yet
Milestone
2021.10
Development

Successfully merging a pull request may close this issue.

feat(Dropdown): Allow for tooltips on aria-disabled items nicolethoen/patternfly-react
4 participants
@mcarrano @nicolethoen @mcoker @tlabaj