chore(webpack): tune webpack config #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only focus new content when user navigates in-app add small delay before sending focus for JAWS
redallen
suggested changes
Aug 6, 2019
redallen
approved these changes
Aug 6, 2019
bhanvimenghani
pushed a commit
to bhanvimenghani/patternfly-react-seed
that referenced
this pull request
Mar 18, 2022
* chore(webpack): tune webpack config only focus new content when user navigates in-app add small delay before sending focus for JAWS * [cleanup] clear timer so they do not queue when switching routes often * [cleanup] fix active state for nav items
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a small pkg to track the last route so that we can fine-tune the AX by not sending focus upon initially loading the app. It also registers a couple of new directories in the webpack config that users are likely to need at some point. Finally, I switched the default "home" route to be "/" instead of "/dashboard".
Related to #55
only focus on new content when a user navigates in-app
add a small delay before sending focus for JAWS