-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix for title size issue. #351
Conversation
✅ Deploy Preview for quickstarts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fix: removed title.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Approving if we want to do the close button update in a follow up, or will re-review if this PR is updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the font size, but calling out that this changes the DOM which could break user tests?
Yes there's a chance this could break users testing. We discussed this and talked about if we should try to not modify the DOM. However after discussing the issue, we decided that we should go ahead with this fix since it was incorrect to begin with, and a fix that would not modify the DOM wouldn't be the correct solution. |
All set @andrew-ronaldson |
🎉 This PR is included in version 6.1.0-prerelease.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fixes issue #342 by removing the extra title tag.