Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tools): correct dev server not serving lightdom.css files #2795

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

zeroedin
Copy link
Collaborator

What I did

  1. Fix dev-server not serving lightdom.css files

Closes #2794

Testing Instructions

  1. Follow instructions in [bug] dev server no longer serves -lightdom.css #2794 ensure lightdom.css and lightdom-shim.css serve.
  2. Launch dev server npm run serve

Notes to Reviewers

@zeroedin zeroedin added the bug label Jun 28, 2024
@zeroedin zeroedin requested a review from bennypowers June 28, 2024 20:48
@zeroedin zeroedin self-assigned this Jun 28, 2024
Copy link

changeset-bot bot commented Jun 28, 2024

⚠️ No Changeset found

Latest commit: 3516d48

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the tools Development and build tools label Jun 28, 2024
Copy link

netlify bot commented Jun 28, 2024

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 9011542
😎 Deploy Preview https://deploy-preview-2795--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the AT passed Automated testing has passed label Jun 28, 2024
@bennypowers
Copy link
Member

iirc there's a fix for this on staging/4.0.

Will check on Sunday

@bennypowers
Copy link
Member

bennypowers commented Jun 30, 2024

Thanks for filing this. I decided to put things in order a bit, so I

  • Removed some unused dependencies
  • Made pfe-tools deps into peerDeps
  • Refactored the dev server plugin to import it's middlewares from purpose-oriented modules
  • Split the router middlewares out into small, directed functions, one per case.
  • Improved the inline documentation for the router functions, hopefully clarifying what each middleware does

I then tested with these steps:

  1. add /elements/accordion/pf-accordion-lightdom.css which sets background to blue
  2. add /elements/accordion/pf-accordion-lightdom-shim.css which sets border to pink
  3. add /elements/accordion/demo/[email protected] copied from /brand
  4. link to both stylesheets and the image from /elements/pf-accordion/demo/pf-accordion.html
  5. link to both stylesheets and the image from /elements/pf-accordion/demo/bordered.html
  6. build and run the dev server
  7. ensure that in both the accordion and bordered demos, the css applies and the image loads
  8. kill the dev server
  9. copy (not npm link, but copy) the contents of tools/pfe-tools/dev-server to rhds repo's node_modules
  10. replace the fully qualified urls in the avatar demos with local demos, and populate those images
  11. run the dev server in the rhds directory
  12. ensure that the avatar, avatar color context, table, and table color context demos render as expected

@github-actions github-actions bot added the doc label Jun 30, 2024
@bennypowers bennypowers enabled auto-merge (squash) June 30, 2024 11:50
@bennypowers bennypowers merged commit b6c3a1f into main Jul 1, 2024
26 checks passed
@bennypowers bennypowers deleted the fix/tools/dev-server-lightdom branch July 1, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AT passed Automated testing has passed bug doc tools Development and build tools
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[bug] dev server no longer serves -lightdom.css
2 participants