Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avatar)!: make size property as abstract #2414

Closed
wants to merge 2 commits into from

Conversation

anujsi
Copy link
Contributor

@anujsi anujsi commented Mar 8, 2023

What I did

  1. Made size property and BaseAvatar class as abstract

fixes - #2349

@changeset-bot
Copy link

changeset-bot bot commented Mar 8, 2023

🦋 Changeset detected

Latest commit: 32cf139

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@anujsingla anujsingla requested a review from bennypowers March 8, 2023 05:22
@bennypowers bennypowers enabled auto-merge (rebase) March 8, 2023 07:13
@bennypowers bennypowers changed the title fix(avatar): make size property as abstract fix(avatar)!: make size property as abstract Mar 10, 2023
@bennypowers bennypowers linked an issue Oct 19, 2023 that may be closed by this pull request
@bennypowers
Copy link
Member

Closed by #2630

auto-merge was automatically disabled April 11, 2024 05:28

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BaseAvatar properties should be abstract
2 participants