Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need placeholder property for pf-text-input component #2594

Closed
kishori-patil1 opened this issue Sep 20, 2023 · 1 comment · Fixed by #2595
Closed

Need placeholder property for pf-text-input component #2594

kishori-patil1 opened this issue Sep 20, 2023 · 1 comment · Fixed by #2595
Labels
feature New feature or request priority: low Severity level: 3

Comments

@kishori-patil1
Copy link

We have a design requirement where we need to add placeholder text in text input. Currently, I don't see this prop present for the pf-text-input component. We need this prop to be added so that we can easily add the placeholder text.

Impacted component(s)

  • pf-text-input

Related issues

  • None
@kishori-patil1 kishori-patil1 added feature New feature or request priority: low Severity level: 3 labels Sep 20, 2023
bennypowers added a commit that referenced this issue Sep 20, 2023
@bennypowers
feat(text-input): placeholder
8d10fec 
Closes #2594
@bennypowers bennypowers mentioned this issue Sep 20, 2023
Merged
brianferry pushed a commit that referenced this issue Sep 20, 2023
@bennypowers
feat(text-input): placeholder (#2595)
45a1a27 
Closes #2594
@bennypowers
Copy link
Member

Thank you for the issue, @kishori-patil1 . This will release with v2.5.0 when #2596 merges

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request priority: low Severity level: 3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(text-input): placeholder patternfly/patternfly-elements
2 participants
@bennypowers @kishori-patil1