Skip to content

Commit

Permalink
Merge branch 'main' into fix/tile/remove-base
Browse files Browse the repository at this point in the history
  • Loading branch information
zeroedin authored and bennypowers committed Apr 11, 2024
2 parents c9bf5d6 + a28644b commit c65286e
Show file tree
Hide file tree
Showing 2,296 changed files with 29,823 additions and 30,410 deletions.
4 changes: 0 additions & 4 deletions .changeset/accordion-no-animate.md

This file was deleted.

6 changes: 6 additions & 0 deletions .changeset/chilly-plums-shake.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@patternfly/eslint-config-elements": major
"@patternfly/eslint-plugin-elements": major
---

Provide ESLint flat config. Upgrade to ESLint 9.0 to use.
4 changes: 4 additions & 0 deletions .changeset/deep-mammals-rescue.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
"@patternfly/pfe-tools": patch
---
Dev Server: update icon and theme colours
4 changes: 4 additions & 0 deletions .changeset/eleven-llamas-follow.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
"@patternfly/elements": patch
---
`<pf-select>`: fixed computed button label when the placeholder attribute is present
17 changes: 17 additions & 0 deletions .changeset/label-close-remove.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
---
"@patternfly/elements": major
---
`<pf-label>`: when clicking close button, `close` event is fired.
Now, if that event is not cancelled, the label will remove itself from the document.

To restore previous behaviour:

```js
import { LabelCloseEvent } from '@patternfly/elements/pf-label/pf-label.js';
label.addEventListener('close', function(event) {
if (event instanceof LabelCloseEvent) {
event.preventDefault();
return false;
}
});
```
4 changes: 0 additions & 4 deletions .changeset/logger-debug.md

This file was deleted.

4 changes: 0 additions & 4 deletions .changeset/pf-text-input-placeholder.md

This file was deleted.

35 changes: 35 additions & 0 deletions .changeset/remove-base-clipboard-copy.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
---
"@patternfly/elements": major
---
`<pf-clipboard-copy>`: Removed `BaseClipboardCopy` class.
Reimplement (recommended) or extend `PfClipboardCopy`.
Renames `AvatarLoadEvent` to `PfAvatarLoadEvent` and moves it to `pf-avatar.js`.

**Before**:

```js
import {
ClipboardCopyCopiedEvent
} from '@patternfly/elements/pf-clipboard-copy/BaseClipboardCopy.js';

addEventListener('copy', function(event) {
if (event instanceof ClipboardCopyCopiedEvent) {
// ...
}
});
```

**After**:

```js
import {
PfClipboardCopyCopiedEvent
} from '@patternfly/elements/pf-clipboard-copy/pf-clipboard-copy.js';

addEventListener('copy', function(event) {
if (event instanceof PfClipboardCopyCopiedEvent) {
// ...
}
});
```

4 changes: 4 additions & 0 deletions .changeset/remove-base-label.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
"@patternfly/elements": major
---
`<pf-label>`: Removed `BaseLabel` class. Reimplement (recommended) or extend `PfLabel`.
4 changes: 4 additions & 0 deletions .changeset/remove-base-switch.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
"@patternfly/elements": major
---
`<pf-switch>`: Removed `BaseSwitch` class. Reimplement (recommended) or extend `PfSwitch`.
29 changes: 29 additions & 0 deletions .changeset/remove-baseavatar.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
---
"@patternfly/elements": major
---
`<pf-avatar>`: Removed `BaseAvatar` class. Reimplement (recommended) or extend `PfAvatar`.
Renames `AvatarLoadEvent` to `PfAvatarLoadEvent` and moves it to `pf-avatar.js`.

**Before**:

```js
import { AvatarLoadEvent } from '@patternfly/elements/pf-avatar/BaseAvatar.js';

addEventListener('load', function(event) {
if (event instanceof AvatarLoadEvent) {
// ...
}
});
```

**After**:

```js
import { PfAvatarLoadEvent } from '@patternfly/elements/pf-avatar/pf-avatar.js';

addEventListener('load', function(event) {
if (event instanceof PfAvatarLoadEvent) {
// ...
}
});
```
4 changes: 4 additions & 0 deletions .changeset/remove-basebadge.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
"@patternfly/elements": major
---
`<pf-badge>`: Removed `BaseBadge` class. Reimplement (recommended) or extend `PfBadge`.
4 changes: 4 additions & 0 deletions .changeset/remove-basecodeblock.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
"@patternfly/elements": major
---
`<pf-code-block>`: Removed `BaseCodeBlock` class. Reimplement (recommended) or extend `PfCodeBlock`.
4 changes: 4 additions & 0 deletions .changeset/remove-basespinner.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
"@patternfly/elements": major
---
`<pf-spinner>`: Removed `BaseSpinner` class. Reimplement (recommended) or extend `PfSpinner`.
4 changes: 4 additions & 0 deletions .changeset/rude-kiwis-live.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
"@patternfly/pfe-tools": patch
---
Update typescript types
4 changes: 0 additions & 4 deletions .changeset/slot-logger.md

This file was deleted.

6 changes: 3 additions & 3 deletions .commitlintrc.cjs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const fs = require("fs");
const path = require("path");
const fs = require('fs');
const path = require('path');
const normalizeWorkspace = x =>
fs.readdirSync(path.join(__dirname, x)).map(x => x.replace('pf-', ''));

Expand All @@ -23,5 +23,5 @@ module.exports = {
...normalizeWorkspace('core'),
...normalizeWorkspace('tools'),
]],
}
},
};
45 changes: 0 additions & 45 deletions .eslintignore

This file was deleted.

13 changes: 0 additions & 13 deletions .eslintrc.json

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/bundle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '18'
node-version: '20'
cache: npm

- name: Bundle
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '18'
node-version: '20'
cache: npm

- name: Verify JSPM URL
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '18'
node-version: '20'
cache: npm

- run: npm ci --prefer-offline
Expand Down
39 changes: 28 additions & 11 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,8 @@ jobs:
# steps:
# - name: Debugging context variables
# run: echo "$GITHUB_CONTEXT"

test:
name: Run test suite (Web Test Runner)
lint:
name: Lint files
runs-on: ubuntu-latest
steps:
- name: Checkout repository
Expand All @@ -52,7 +51,7 @@ jobs:
- name: Configure node version
uses: actions/setup-node@v3
with:
node-version: '18'
node-version: '20'
cache: npm

- name: Install dependencies
Expand All @@ -62,13 +61,32 @@ jobs:
id: lint
run: npm run lint


test:
name: Run test suite (Web Test Runner)
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v3

# Configures the node version used on GitHub-hosted runners
- name: Configure node version
uses: actions/setup-node@v3
with:
node-version: '20'
cache: npm

- name: Install dependencies
run: npm ci --prefer-offline

- name: install playwright
run: npx playwright install

- name: Run tests
run: npm test
if: ${{ always() }}

- name: JUnit Report Action
uses: mikepenz/[email protected]
if: ${{ always() }}
with:
report_paths: test-results/test-results.xml
fail_on_failure: true # fail the actions run if the tests failed
Expand All @@ -79,10 +97,8 @@ jobs:
strategy:
matrix:
node:
- '18'
- '19'
# https://github.com/TypeStrong/ts-node/issues/1997
# - '20'
- '20'
- '21'
if: |
github.event_name == 'workflow_dispatch'
|| github.event_name == 'push'
Expand Down Expand Up @@ -126,8 +142,9 @@ jobs:
validate:
name: Validate successful build on main
needs:
- build
- lint
- test
- build
if: ${{ always() }}
runs-on: ubuntu-latest
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/visual-regression.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '18'
node-version: '20'
cache: npm
- run: npm ci --prefer-offline

Expand Down
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,12 @@ tools/*/test/**/*.png
!core/*/demo/*
!tools/*/demo/*

elements/pf-icon/icons
!elements/pf-icon/demo/icons/**/*.js

!scripts/**/*.js

!tools/eslint-plugin/index.js
!tools/eslint-config/**/*.js

*.tgz
custom-elements.json
Expand Down
3 changes: 0 additions & 3 deletions .husky/commit-msg
Original file line number Diff line number Diff line change
@@ -1,4 +1 @@
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

npx --no -- commitlint --edit "$1"
1 change: 0 additions & 1 deletion .husky/pre-commit
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
#!/bin/sh
npx lint-staged
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v18.12.1
v20.10.0
8 changes: 7 additions & 1 deletion brand/logo/svg/pfe-icon-white.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading

0 comments on commit c65286e

Please sign in to comment.