-
Notifications
You must be signed in to change notification settings - Fork 96
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(accordion)!: remove BaseAccordion
Closes #2612 fix(accordion): expand logic refactor(accordion): prevent circular imports
- Loading branch information
1 parent
77dff66
commit af07dc2
Showing
11 changed files
with
535 additions
and
599 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
--- | ||
"@patternfly/elements": major | ||
--- | ||
`<pf-accordion>`: Removed `BaseAccordion*` classes, as well as static `isPanel`, `isHeader`, and `isAccordion` methods. Removed the optional `parentAccordion` parameter to `PfAccordion#expand(index)`. Renamed accordion event classes by adding the `Pf` prefix: | ||
|
||
**Before**: | ||
|
||
```js | ||
import { | ||
AccordionHeaderChangeEvent | ||
} from '@patternfly/elements/pf-accordion/pf-accordion.js'; | ||
|
||
addEventListener('change', function(event) { | ||
if (event instanceof AccordionHeaderChangeEvent) { | ||
// ... | ||
} | ||
}); | ||
``` | ||
|
||
**After**: | ||
|
||
```js | ||
import { | ||
PfAccordionHeaderChangeEvent | ||
} from '@patternfly/elements/pf-accordion/pf-accordion.js'; | ||
|
||
addEventListener('change', function(event) { | ||
if (event instanceof PfAccordionHeaderChangeEvent) { | ||
// ... | ||
} | ||
}); | ||
``` |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.