Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💣MONOREPO #806

Merged
merged 1,359 commits into from
Feb 27, 2018
Merged

💣MONOREPO #806

merged 1,359 commits into from
Feb 27, 2018

Conversation

bmuenzenmeyer
Copy link
Member

Closers #803

Summary of changes:

  • Thirteen repositories now reside under packages/

More to come!

geoffp and others added 30 commits February 23, 2018 12:18
@geoffp
*temporarily* add template renderers to package.json just so our unit…
d282fb5 
… tests actually mean something in Travis/GitHub
@geoffp
Don't run handlebars unit tests if handlebars isn't installed
cbb6c42
@geoffp
Merge commit 'upstream/dev^' into pattern-engines
46e235f
@geoffp
Merge branch 'dev' into pattern-engines
ea67da7
@geoffp
Merge remote-tracking branch 'refs/remotes/upstream/dev' into pattern…
c83212e 
…-engines
@geoffp
move pattern engines and utilities to the new core/lib location and f…
7b5b4ae 
…ix stray references to changed paths
@geoffp
Fix a total misinterpretation of underscore-prefixed patterns: they'r…
ea841c2 
…e not supposed to be completely excluded from processing, they're just supposed to not appear in the nav, styleguide, or view all views. Per http://patternlab.io/docs/pattern-hiding.html
@geoffp
Merge pull request #279 from sghoweri/pattern-engines
f5c7738 
v3 Twig Engine Integration
@geoffp
tell the linter to chill out about some things
efab7d1
@geoffp
code cleanups and linter appeasement
1afc245
@geoffp
Clean up code in engine_twig and move to the correct location
6dbaf4f
@geoffp
Tweaks, cleanups and unit tests for the Twig engine.
10b8c21
@geoffp
oops, debugger statement
546591d
@geoffp
Merge pull request #286 from EvanLovely/feature/pattern-engines-tweaks
b390b46 
pattern engines tweaks
@geoffp
fix whitespace in lineage-hunter test
b2d65e4
@geoffp
Merge remote-tracking branch 'refs/remotes/upstream/dev' into pattern…
f28b8ed 
…-engines
@geoffp
Change underscore engine extension to html
c5db26f
@geoffp
rename underscore test templates to .html
dc106f8
@geoffp
fix underscore unit tests
4d73212
@geoffp
Merge branch 'dev' into pattern-engines
d50133d
@geoffp
Merge pull request #278 from e2tha-e/pattern-engines-docblock-update
d680a39 
a more accurate docblock
@geoffp
Handle undefined variables in underscore templates
3baeb8e
@geoffp
factor out the UI Builder into its own module -- just get it working …
9a52e25 
…for now.
@geoffp
factor out assembleStyleguidePatterns()
f2682eb
@geoffp
factor out buildViewAllPages()
edf1ea5
@geoffp
factor out buildNavigation()
1189809
@geoffp
comment placement adjustment to not lie
3176be8
@geoffp
factor out sortPatterns()
3e99dbb
@geoffp
comments
200252e
@geoffp
factor out pattern exclusion from buildNavigation()
ac8676c
geoffp and others added 18 commits February 23, 2018 14:27
@geoffp
Update the Twig engine to the top of its develop branch
0a2780e
@geoffp
Merge branch 'lerna-monorepo' of github.com:pattern-lab/patternlab-no…
5482276 
…de into lerna-monorepo
@geoffp
More lockfiles and a quick README update
7318346
@geoffp
Move and add the PL logo to the README!
844093b
@geoffp
Update README
5e0c6f3
@geoffp
Move the badges
a24fc36
@geoffp
More README updates
5171088
@geoffp
Let's try this again.
df7327e
@geoffp
Make the logo smaller and center it
f5c7725
@geoffp
Flip the logo and heading
5e0f6f4
@raphaelokon
Porting pattern-lab/patternlab-node-cli #55
9b9cf78
@bmuenzenmeyer
chore(tests): Remove test artifact
fb9635a
@bmuenzenmeyer
fix(prettier): Attempt to ignore package files
e6c08bf
@bmuenzenmeyer
fix(core): Fix tests
31d67a7
@bmuenzenmeyer
feat(package): Hoist up tap and test command.
6cacdb6 
Not sure if this is best approach vs `lerna run` @geoffp
@bmuenzenmeyer
chore(prettier): Prettier thrashing package-lock files
3e1adf0
@bmuenzenmeyer
chore(core): Stop tracking test artifact
693f8c1
@bmuenzenmeyer
chore(travis): Revert lerna-bootstrap branch, let's PR!
8bc38c6
@bmuenzenmeyer bmuenzenmeyer added this to the 3.0.0 milestone Feb 27, 2018
@bmuenzenmeyer bmuenzenmeyer self-assigned this Feb 27, 2018
@bmuenzenmeyer bmuenzenmeyer requested a review from geoffp February 27, 2018 14:38
@bmuenzenmeyer bmuenzenmeyer changed the base branch from master to dev February 27, 2018 14:38
@coveralls
Copy link

Coverage Status

Coverage increased (+2.0%) to 75.202% when pulling 58f7ec1 on lerna-monorepo into bcf60e4 on dev.

geoffp
geoffp approved these changes Feb 27, 2018
View reviewed changes
Copy link
Contributor

@geoffp geoffp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fabulous! I obviously can't go over every file, but it looks like you've made sensible fixes since hack day.

Let's get this merged ASAP and do a test publish.

@bmuenzenmeyer bmuenzenmeyer merged commit f7c70b8 into dev Feb 27, 2018
@bmuenzenmeyer bmuenzenmeyer deleted the lerna-monorepo branch February 27, 2018 17:03
@sghoweri sghoweri mentioned this pull request Jan 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffp geoffp geoffp approved these changes

Assignees

@bmuenzenmeyer bmuenzenmeyer

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@bmuenzenmeyer @coveralls @geoffp @raphaelokon