Adding routine to copy js along pattern build #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@raphaelokon this works pretty slick - nice work! This is the original output:
I've changed it slightly so the file name output is the same as one would include the partial itself:
This has the following benefits.
<script src="atoms-brands-colors.js"></script>
<script src="{{patternPartial}}.js"></script>This works because I am renaming the file during copy, as you'll see in my commit, and then explicitly adding The source files still follow the same convention (same name, different ext):
BONUS ✨By adding <body class="{{ bodyClass }} {{ patternPartial }}"><script>if ('{{patternPartial}}' === 'pages-splash') { ... }</script>though I dont know if the later is a good idea ⚔️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #717
Summary of changes: