chore: adding simple pattern descriptions #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
especially for testing
as it got moved to the description previously
JosefBredereck
approved these changes
Dec 2, 2021
mfranzke
added a commit
to mfranzke/patternlab-node
that referenced
this pull request
Dec 4, 2021
* chore: adding pattern simple descriptions especially for testing * chore: removed the comment as it got moved to the description previously
JosefBredereck
pushed a commit
that referenced
this pull request
Dec 4, 2021
* chore(docs): some typos missed to replace mustache initially and incorrect handlebars two times (both in package name and URL) * Revert "Merge pull request #2 from pattern-lab/dev" This reverts commit 7812878, reversing changes made to 26db979. * Revert "Merge pull request #1 from pattern-lab/dev" This reverts commit 26db979, reversing changes made to fc90750. * Revert "chore(docs): some typos" This reverts commit 271dc8d. * refactor: updated lerna dependency executed a simple migration script as stated in https://github.com/lerna/lerna/blob/main/CHANGELOG.md#400-2021-02-10 * chore: formatting * chore: code optimizations that are mentioned by the github pipeline as well * chore: formatting * Revert "chore: formatting" This reverts commit 60a3d64. * chore:formatting * chore: formatting * Revert "Merge branch 'dev' into refactor/updated-lerna-dependency" This reverts commit ab5e103, reversing changes made to e7123c1. * Revert "chore: formatting" This reverts commit e7123c1. * chore: formatting * Revert "Revert "Merge branch 'dev' into refactor/updated-lerna-dependency"" This reverts commit ed365ea. * Revert "Revert "Revert "Merge branch 'dev' into refactor/updated-lerna-dependency""" This reverts commit 2c27360. * refactor: moved dependencies to devDependencies @ cli (#1384) * refactor: moved dependencies to devDependencies * build: regenerated package-lock.json * chore: reformatting * chore: code optimizations that are mentioned by the github pipeline as well * Revert "chore: reformatting" This reverts commit a5cfdd5. * build: regenerated package-lock.json * refactor: updated 11ty dependencies (#1383) * refactor: updated 11ty dependencies * Revert "refactor: updated 11ty dependencies" This reverts commit f9743ed. * build: updated @11ty/eleventy-plugin-rss dependency * chore: formatting * chore: code optimizations that are mentioned by the github pipeline as well * Revert "chore: formatting" This reverts commit 8abf6fc. * build: updated @11ty/eleventy-navigation dependency * chore: formatting * build: updated @11ty/eleventy-plugin-syntaxhighlight dependency * Revert "chore: formatting" This reverts commit cd323e7. * build: updated @11ty/eleventy dependency * chore: formattingbuild: updated @11ty/eleventy dependency * build: regenerated package-lock.json * build: regenerated yarn.lock * feat: define initial viewport (#1386) * refactor: updated http-auth dependency (#1379) * refactor: updated http-auth dependency http-auth: added necessary new dependency http-auth-connect that provides the method .connect that got extracted from the original one. * chore: formatting * chore: code optimizations that are mentioned by the github pipeline as well * Revert "chore: formatting" This reverts commit 5b7a95b. * chore: adding simple pattern descriptions (#1378) * chore: adding pattern simple descriptions especially for testing * chore: removed the comment as it got moved to the description previously * Revert "chore: formatting" This reverts commit 4ffd569. * Revert "chore:formatting" This reverts commit c21504b. * build: regenerated yarn.lock Co-authored-by: Maximilian <[email protected]>
antonia-rose
pushed a commit
to quelltexterin/nemo-uikit-workshop
that referenced
this pull request
Apr 12, 2023
* chore(docs): some typos missed to replace mustache initially and incorrect handlebars two times (both in package name and URL) * Revert "Merge pull request pattern-lab#2 from pattern-lab/dev" This reverts commit 7812878, reversing changes made to 26db979. * Revert "Merge pull request pattern-lab#1 from pattern-lab/dev" This reverts commit 26db979, reversing changes made to fc90750. * Revert "chore(docs): some typos" This reverts commit 271dc8d. * refactor: updated lerna dependency executed a simple migration script as stated in https://github.com/lerna/lerna/blob/main/CHANGELOG.md#400-2021-02-10 * chore: formatting * chore: code optimizations that are mentioned by the github pipeline as well * chore: formatting * Revert "chore: formatting" This reverts commit 60a3d64. * chore:formatting * chore: formatting * Revert "Merge branch 'dev' into refactor/updated-lerna-dependency" This reverts commit ab5e103, reversing changes made to e7123c1. * Revert "chore: formatting" This reverts commit e7123c1. * chore: formatting * Revert "Revert "Merge branch 'dev' into refactor/updated-lerna-dependency"" This reverts commit ed365ea. * Revert "Revert "Revert "Merge branch 'dev' into refactor/updated-lerna-dependency""" This reverts commit 2c27360. * refactor: moved dependencies to devDependencies @ cli (pattern-lab#1384) * refactor: moved dependencies to devDependencies * build: regenerated package-lock.json * chore: reformatting * chore: code optimizations that are mentioned by the github pipeline as well * Revert "chore: reformatting" This reverts commit a5cfdd5. * build: regenerated package-lock.json * refactor: updated 11ty dependencies (pattern-lab#1383) * refactor: updated 11ty dependencies * Revert "refactor: updated 11ty dependencies" This reverts commit f9743ed. * build: updated @11ty/eleventy-plugin-rss dependency * chore: formatting * chore: code optimizations that are mentioned by the github pipeline as well * Revert "chore: formatting" This reverts commit 8abf6fc. * build: updated @11ty/eleventy-navigation dependency * chore: formatting * build: updated @11ty/eleventy-plugin-syntaxhighlight dependency * Revert "chore: formatting" This reverts commit cd323e7. * build: updated @11ty/eleventy dependency * chore: formattingbuild: updated @11ty/eleventy dependency * build: regenerated package-lock.json * build: regenerated yarn.lock * feat: define initial viewport (pattern-lab#1386) * refactor: updated http-auth dependency (pattern-lab#1379) * refactor: updated http-auth dependency http-auth: added necessary new dependency http-auth-connect that provides the method .connect that got extracted from the original one. * chore: formatting * chore: code optimizations that are mentioned by the github pipeline as well * Revert "chore: formatting" This reverts commit 5b7a95b. * chore: adding simple pattern descriptions (pattern-lab#1378) * chore: adding pattern simple descriptions especially for testing * chore: removed the comment as it got moved to the description previously * Revert "chore: formatting" This reverts commit 4ffd569. * Revert "chore:formatting" This reverts commit c21504b. * build: regenerated yarn.lock Co-authored-by: Maximilian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've recognized that we don't have any descriptions for our patterns so far (only for the button group), and it might be especially beneficial for testing the UI to have at least some descriptions in the source code.
Summary of changes:
Just moved the textual additions to two of our patterns. Nothing special.