-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: updated even further dependencies #1320
Merged
JosefBredereck
merged 131 commits into
pattern-lab:dev
from
mfranzke:refactor-updated-even-further-dependencies
Jan 29, 2022
Merged
refactor: updated even further dependencies #1320
JosefBredereck
merged 131 commits into
pattern-lab:dev
from
mfranzke:refactor-updated-even-further-dependencies
Jan 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get upstream
get upstream
missed to replace mustache initially and incorrect handlebars two times (both in package name and URL)
This reverts commit 271dc8d.
mfranzke
changed the title
refactor: updated even further dependencies
refactor: updated even further devDependencies
Dec 17, 2021
mfranzke
changed the title
refactor: updated even further devDependencies
refactor: updated even further dependencies
Dec 17, 2021
…github.com/mfranzke/patternlab-node into refactor-updated-even-further-dependencies
…n-further-dependencies
…n-further-dependencies
JosefBredereck
approved these changes
Jan 29, 2022
PR was released with v5.16.0 |
antonia-rose
pushed a commit
to quelltexterin/nemo-uikit-workshop
that referenced
this pull request
Apr 12, 2023
* chore(docs): some typos missed to replace mustache initially and incorrect handlebars two times (both in package name and URL) * Revert "Merge pull request pattern-lab#2 from pattern-lab/dev" This reverts commit 7812878, reversing changes made to 26db979. * Revert "Merge pull request pattern-lab#1 from pattern-lab/dev" This reverts commit 26db979, reversing changes made to fc90750. * Revert "chore(docs): some typos" This reverts commit 271dc8d. * refactor: updated dependency ejs * refactor: updated dependency scroll-js * refactor: updated dependency classnames * refactor: updated dependency gulp * refactor: replaced dependency opn by its new name open * refactor: updated dependency lerna and executed a simple migration script as stated in https://github.com/lerna/lerna/blob/main/CHANGELOG.md#400-2021-02-10 * refactor: updated dependency @auto-it/released * refactor: updated dependency auto * refactor: updated dependency fs-extra * refactor: updated dependency better-opn * refactor: updated dependency cosmiconfig * fix(cosmiconfig-update): corrected the variable name * fix(cosmiconfig-update): added the variable name * refactor: updated dependency fuse.js * refactor: updated dependency deepmerge * refactor: updated dependency execa * refactor: updated dependency js-yaml * refactor: updated dependency jsdoc-to-markdown * refactor: updated dependency archiver * refactor: updated dependency has-yarn * refactor: updated dependency inquirer * refactor: updated dependency ora * refactor: updated dependency http-auth and added necessary new dependency http-auth-connect that provides a method that got extracted from the original one. * refactor(node): aligned all node versions within the packages * refactor: updated dependency node-sass * refactor: updated dependency open * refactor: updated dependency yargs * refactor: updated dependency @11ty/eleventy-plugin-syntaxhighlight * refactor: updated dependency markdown-it * build: regenerated yarn.lock file * refactor: updated dependency node-sass pattern-lab#1320 * refactor: updated dependency recursive-copy * chore: reverted node-sass dependency update * refactor: rebuild yarn.lock file * refactor(node): aligned all node versions within the packages * build: regenerated yarn.lock file * refactor: updated dependency husky * refactor: updated dependency @11ty/eleventy * chore: code optimizations that are mentioned by the github pipeline as well * chore: rebuild yarn.lock file * chore: some reformatting * chore: rebuild yarn.lock file * chore: reformatted * chore: reverted commit a852046 * Revert "chore: reformatted" This reverts commit 1531399. * chore: formatting * chore: formatting * chore: formatting * chore: formatting This reverts commit 271dc8d. * chore: formatting * chore: formatting * build: regenerated package-lock.json * refactor: revert commit 373ea94 and 9b60cf2 * chore: reformatting * fix: corrected those files contents * refactor: updated dependency send * refactor: updated dependency commander * refactor: we need to fix this dependencies version range to minor * build: regenerated yarn.lock file Co-authored-by: Maximilian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
Please find the list of all of the changed dependencies with their related breaking changes for all major release updates listed below them. I've as well compared the handlebars and twig
build
output to ensure that this update is fine.Simply updated
Not used by us
Not used by us
Not relevant for us, as this is out of (below) our Node version scope.
But we need to fix the version at
3.4.x
as with version3.5.0
a breaking change of jumping from node version 12 to 16 got introduced.changes documented within the API with commit gulpjs/gulp@0f3151e; no noticeable changes for our implementation
Not used by our codebase.
Not used by our codebase.
Not used by our codebase.
fine with our node.js support
clobber
tooverwrite
. This affectscopy()
,copySync()
, andmove()
. #330, #333we don't use this one
v0.12
. The Node foundation stopped officially supporting it on Jan 1st, 2017.fine with our node.js support
walk()
andwalkSync()
.walkSync()
was only part offs-extra
for a little over two months. Use klaw instead ofwalk()
, in fact,walk()
was just an alias to klaw. ForwalkSync()
use klaw-sync. See: #338, #339we don't use these ones
fs
methods andfs-extra
methods now return a promise if the callback is not passed. #403This one was added with
fs-extra
major version 3.0.0 – we're only using the async functions in packages that were on higher versions of that dependency even already, and sync elsewhere.writeJson()
,writeJsonSync()
,outputJson()
, &outputJsonSync()
. This was undocumented. BREAKING: Remove support for setting spaces for JSON writing jprichardson/node-fs-extra#402We don't use that undocumented way of defining spaces.
throws
option forreadJsonSync()
; now does not throw filesystem errors whenthrows
isfalse
.we don't use this one
writeJson()
,writeJsonSync()
,outputJson()
, &outputJsonSync()
now output minified JSON by default for consistency withJSON.stringify()
; set thespaces
option to2
to override this new behavior. BREAKING: Remove support for setting spaces for JSON writing jprichardson/node-fs-extra#402We don't use
fs.spaces
, that has been removed there.fs.read()
&fs.write()
now return objects. See the docs for details. #436, #449we don't use these ones
copy()
©Sync()
, including breaking changesWe don't use these
filter
optionsfilter
option can no longer be a RegExp (must be a function). This was deprecated since fs-extra v1.0.0. #512copy()
'sfilter
option can now be a function that returns a Promise. #518fine with our node.js support
copy*()
handling of symlinks to properly detect symlinks that point to the same file. (#582)To my knowledge we don't use symlinks
fine with our node.js support
ensureDir*
to use a fork of https://github.com/sindresorhus/make-dir to make use of native recursivefs.mkdir
where possible (#619, #756)Shouldn't be a problem for us. In detail:
fs.mkdir
)fs.mkdir
)atime
forcopy*
withpreserveTimestamps
option (#633)We don't use this option.
outputJson
now outputs objects as they were when the function was called, even if they are mutated later (#702, #768)I can't see how this would affect us negatively.
null
as an options parameter to*Json*
methods (#745, #768)We don't do this.
fine with our node.js support
To my knowledge we don't use symlinks
ensureLink*()
/ensureSymlink*()
(#826, #786, #870)We don't use these methods.
copy*()
unknown file type (#880)I can't see how this would affect us.
remove*()
(#882)We don't use any
remove*()
functionfine with our node.js support
app
option now accepts an object instead of a string/array:We don't use this option.
Fine for us as we're using the Common JS version.
main
entry point inpackage.json
is now a CommonJS module instead of a UMD module #155Fine for us as we're using the Common JS version.
We're aren't depending on the exact error message.
fine with our node.js support
fine with our node.js support
fine with our node.js support
we do.
fine with our node.js support
I can't see how this would affect us.
fine with our node.js support
fine with our node.js support
fine with our node.js support
enabled
option toisEnabled
sindresorhus/ora@fc5c660We don't use this option.
iEnabled
sindresorhus/ora@d1f8d85I can't see how this would affect us.
fine with our node.js support
I can't see how this would affect us.
We don't use this method.
We don't use
yargs-factory
.We don't use that method.
I can't see how this would affect us.
I can't see how this would affect us.
I can't see how this would affect us.
I can't see how these would affect us.
I can't see how this would affect us.
We don't use this one.
We don't use this one.
linkify-it
was changed. You will not be affected anyhow, if not used direct access torequire('linkify-it/re')
for customizations.We don't access
require('linkify-it/re')
directly.I can't see how this would affect us.
send
commander
-n
accessed asopts().n
(previously uppercase)Not in use by us.
We don't get an error like this.
Not in use by us
.allowUnknownOption()
(#802 #1138)Not in use by us
.args
.parseOptions()
(#1138)Not in use by us
args
in returned result renamedoperands
and does not include anything after first unknown optionunknown
option including operands, not just options and values.on('command:*', callback)
and other command events passed (changed) results from.parseOptions
, i.e. operands and unknown (#1138)We're on Node 12
.command
. (#938 #990)--no-foo
on cli now emitsoption:no-foo
(previouslyoption:foo
)--no-foo
after defining--foo
leaves the default value unchanged (previously set it to false)Updated and migrated some code
safeLoad()
,safeLoadAll()
,safeDump()
=>load()
,loadAll()
,dump()
.husky/
directory structure..husky/.gitignore
is now unnecessary and can be removed.Did that.
Not relevant for us, as we're on Node 12
Replaced
opn
got renamed toopen
(still maintained by @sindresorhus).#updatingdependenciesbitbybitbybitbybitbybitbybitbybitbybit