Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data from listItems are not passed through in the loop #685

Closed
bramsmulders opened this issue Sep 19, 2017 · 3 comments
Closed

Data from listItems are not passed through in the loop #685

bramsmulders opened this issue Sep 19, 2017 · 3 comments

Comments

@bramsmulders
Copy link
Contributor

I am using Pattern Lab Node v2.11.0 on Mac, with Node v6.11.3, using the Gulp Edition.

Expected Behavior

Should render three different titles harvested from _data/listitems.json.

Actual Behavior

Renders three times the same title attribute which is defined in _data/data.json

Steps to Reproduce

Consider this template code:

{{#listItems.three}}
{{title}}
{{/listItems.three}}

Note: it is working in PL-node v2.9.3 so it has to be a problem with the refactoring of data in the latest release.

bmuenzenmeyer added a commit that referenced this issue Sep 19, 2017
@bmuenzenmeyer
Copy link
Member

bmuenzenmeyer commented Sep 19, 2017

@bramsmulders I'll need to do some more testing, but my unit test coverage is passing for this so far.... but it's failing when run against real patterns.

time to dig in

@bmuenzenmeyer
Copy link
Member

found it. fix incoming

@bramsmulders
Copy link
Contributor Author

Whoop! thnx @bmuenzenmeyer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants