Allow engines to support multple extensions

[bmuenzenmeyer]

I am using Pattern Lab Node v2 and v3 on Windows, with Node v6.9.5, using the Gulp Edition.

Expected Behavior

PatternEngines that support more than one common file extension for their template type should be forgiving and accomodate user preference. Examples

• Handlebars: .handlebars vs .hbs - pattern-lab/patternengine-node-handlebars@8c48eb4
• React: .jsx vs .js - pattern-lab/patternengine-node-react@d945e2b
• Underscore: .html vs .underscore - pattern-lab/patternengine-node-underscore@de327f9

Actual Behavior

• Only one type is hard-coded into the engine. This causes problems with watches and the pattern code viewer and is detrimental to user adoption.

[raphaelokon]

Modules and scripts in JS

• .mjs and .js

[bmuenzenmeyer]

For which engine would that be? This issue is limited to PatternEngine use cases, not file watches of client-side javascript.

[raphaelokon]

Each engine that is using a Javascript module semantics (ES6 module syntax) in Node ecosystem?

[geoffp]

With the engines that we currently have, .js would be reserved for React, but we should also think of what kinds of files an Ember or Polymer / Web Components component engine might look for. I don't know those well enough to be able to say. I think Ember does Handlebars, or at least it used to.

[bmuenzenmeyer]

Maybe I am missing something, but my intent for this issue was to alter https://github.com/pattern-lab/patternengine-node-handlebars/blob/master/lib/engine_handlebars.js#L40 to be an array of exentions that make sense for the engine. Not sure how we would handle mixed trees with overlapping capabilities, however.

[geoffp]

I agree, that's what we're doing. It would get pretty complicated to have a file extension claimed by more than one engine; I don't want to do that unless we really have to.

[geoffp]

Well, maybe not if mixed trees really are rare. Sorry, I think I'm too much in that mentality. We don't even have a mixed tree anymore.

[raphaelokon]

@bmuenzenmeyer I think I got it wrong.
From a user perspective: Would it be possible to use an engine (I am actually working on something) that uses plain ES6 template literals and is essentially pure JS?

[geoffp]

@raphaelokon I think it would, so long as you don't also have the React engine installed, which would introduce that conflict for .js files.

[raphaelokon]

@geoffp Cheers. Makes sense.

[bmuenzenmeyer]

Okay. Perhaps we officially de-scope support mixed trees. @raphaelokon that sounds killer

…

On Wed, Feb 15, 2017, 10:09 AM Raphael Okon ***@***.***> wrote: @geoffp <https://github.com/geoffp> Cheers. Makes sense. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#623 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AASNw2MXzZlsheDf7xX9F-6ZB55Z3tRTks5rcyNQgaJpZM4MB0Em> .

[geoffp]

@bmuenzenmeyer mixed trees were a useful way for us to incrementally migrate our technology stack. I'd hate to see us prohibit it, but it does seem very reasonable for us not to go way out of our way to support it.

@raphaelokon are you doing some pure-functional JS templates or something? Tell us more! Is there editor support for markup in ES6 template literals?

[bmuenzenmeyer]

@geoffp agreed. Or tree is a mix right now, but transitionary... more and more moving to handlebars every day

…

On Wed, Feb 15, 2017, 10:18 AM Geoff Pursell ***@***.***> wrote: @bmuenzenmeyer <https://github.com/bmuenzenmeyer> mixed trees were a useful way for us to incrementally migrate our technology stack. I'd hate to see us prohibit it, but it does seem very reasonable for us not to go way out our way to support it. @raphaelokon <https://github.com/raphaelokon> are you doing some pure-functional JS templates or something? Tell us more! Is there editor support for markup in ES6 template literals? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#623 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AASNw92hJ1JAFa-OFtBZKN6LKR3sMFWNks5rcyVWgaJpZM4MB0Em> .

[geoffp]

@bmuenzenmeyer I've got serious love for Handlebars. Such a great authoring experience.

[raphaelokon]

@geoffp Yes. Basically it is a super simple template engine. PHPStorm highlights the html inside template literals and tagged literals templates. Also agree on handlebars.

[bmuenzenmeyer]

@geoffp @raphaelokon 🔥 🔥 🔥