Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental builds: Setting cleanPublic = true after incremental build does not recompile all patterns. #581

Closed
tburny opened this issue Dec 23, 2016 · 0 comments

Comments

@tburny
Copy link

tburny commented Dec 23, 2016

I am using Pattern Lab Node v2.7.0-alpha on Linux, with Node v4.6.2, using the Grunt Edition.

Expected Behavior

When cleanPublic = true is set as configuration option, PL should simply rebuild all patterns.

Actual Behavior

It might be that the serialized graph

  • becomes out of sync with the file system, resulting in unspecified behaviour
  • that there are already compiled templates, thus the according patterns are only recompiled when modified
Steps to Reproduce
  • Build your patternlab with cleanPublic = false
  • Set cleanPublic = true
  • Delete some files in the pattern output directory / modify some pattern templates
  • If there still is a template output or an existing graph file, only some patterns will be rebuilt or there are errors.
@tburny tburny self-assigned this Dec 23, 2016
tburny pushed a commit that referenced this issue Dec 23, 2016
…ng cleanPublic = true after incremental build does not recompile all patterns.
tburny pushed a commit that referenced this issue Dec 23, 2016
…ng cleanPublic = true after incremental build does not recompile all patterns.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants