Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling issues with horizontally split panel #1100

Closed
thethomic opened this issue Nov 18, 2019 · 6 comments · Fixed by #1101
Closed

Styling issues with horizontally split panel #1100

thethomic opened this issue Nov 18, 2019 · 6 comments · Fixed by #1101

Comments

@thethomic
Copy link

thethomic commented Nov 18, 2019

I am using Pattern Lab Node v5.3.0 on Windows, with Node v12.12.0, using a Gulp/mustache Edition.

I switched the layout, so that the menu is on the left side.
This way the code panel gets shown at the bottom, where is now has double scrollbars and a little styling error.
image

Expected Behavior

The info Panel has just one scrollbar on the right side, the code is shown on a white background.

Actual Behavior

There are two scrollbars, the white background is ending to early, there is a white gradient showing

Steps to Reproduce

Open patternlab
switch layout to show the menu on the left side
expand "panel" with code

@bmuenzenmeyer
Copy link
Member

Node 6 is a very outdated and unsupported platform.

Can you try upgrading to node 12.13.0 or even 10 LTS and try again?

https://nodejs.org/en/about/releases/

@bmuenzenmeyer
Copy link
Member

Hmmm your OP mentions node 6 but no longer. What version are you on?

@thethomic
Copy link
Author

I'm sorry 6.11.3 was the npm version..
I'm on node 12.12.0

@thethomic
Copy link
Author

Additional Info:
Happens on latest firefox (developer edition), not in Chrome and only when code height needs to get scrollable.
The element .pl-c-tabs__content has a height: 100% which is adding up to more than 100% together with .pl-c-tabs__header

@sghoweri
Copy link
Contributor

sghoweri commented Nov 21, 2019

Hmmm. This definitely looks like a Firefox rendering quirk (also seeing this in Firefox 70 for OSX).

I’ll see if we can get a CSS fix for this out by the weekend!

@thethomic
Copy link
Author

Hey!
I confirm that the described issue has been fixed!
If you're searching for perfection ;) I have another finding at the same spot for you:

When the CodePanel is scrolled, there is a nice shadow appearing at the top to indicate the covered content. That shadow has a margin to the header (where the margin should visually be coming from)
The margin-bottom of the element .pl-c-tabs__header should be removed for visual coherence.

image

antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this issue Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants