Add ability to automatically forward all attributes to component props #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
patricknelson
force-pushed
the
issue-34-auto-forward-attribs
branch
from
84f5905 to
f08ea86
Compare
patricknelson
force-pushed
the
issue-34-auto-forward-attribs
branch
from
2a24842 to
8fc2742
Compare
…ributes" option, allowing ability to forward all attributes in a v1 compatible fashion.
…MutationObserver.
…and experimental "autoDefine()" function (due to large number of components). Undocumented for a reason... please do not use in production! 😅
…a major use case for it.
…onverting to using querySelector instead of the old original naive HTML comparison tests.
patricknelson
force-pushed
the
issue-34-auto-forward-attribs
branch
from
8fc2742 to
cffccb1
Compare
…or not) under all expected circumstances
…as expected even if element is disconnected from DOM and reconnected again later.
|
Done but gonna let it simmer over night. 🥘 |
patricknelson
commented
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve issue #34 for v1 (as a transitional step to v2) that is backward compatible in a non-breaking way to the existing v1 API.
Adds ability to automatically forward all attributes to component props
attributesfunctionality (not compat w/ Svelte 4'scustomElementsAPI)(or move to direct(chose to just point to../../inclusion instead 🤔)latesttag and not usepackage-lock.json, see ae0501f already inmain)