refactor: use query stream for automatic data update script #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 31, 2024 17:28
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
patrickhulce
requested changes
Aug 7, 2024
Co-authored-by: Patrick Hulce <[email protected]>
patrickhulce
reviewed
Aug 7, 2024
patrickhulce
approved these changes
Aug 7, 2024
|
🎉 This PR is included in version 0.25.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
While customizing SQL queries for future PRs, I got an error due to very large query results from big query.
Issue occurs because of
JSON.stringifycan't be handle very large json results. It throwsRangeError: Invalid string length. This issue makes script not scalable.Moving to stream fixes the issue as data is handled row by row (written to file and inserted in db).
Overwrite lighthouse-infrastructure project
This MR also adds a new environment variable
OVERRIDE_LH_PROJECTto overwrite project containingthird-party-tablewhere script will create a new table (the one where we store mapping between observed domain and canonical one) then queried byentity-per-page.sql. It'll help in case script runner has no write access to hardcoded project in sql script (i.elighthouse-infrastructure).