Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the issuance of multiple verifiable credentials based on a directory attribute. #275

Merged

Conversation

mjspi
Copy link
Collaborator

@mjspi mjspi commented Oct 31, 2023

API Reference: Credential Types | Issue Multiple Credentials to a User Based on a Directory Attribute

  • Add multiple object, and its expression property to the CredentialType object.
  • Add default property to the fields property object in the CredentialTypeMetaData object.

pingone_credential_type regression tests:

 TF_LOG=INFO TF_LOG_PATH=`pwd`/output.log TF_ACC=1 go test -v -timeout 240s  -run TestAccCredentialType_ github.com/pingidentity/terraform-provider-pingone/internal/service/credentials
=== RUN   TestAccCredentialType_RemovalDrift
=== PAUSE TestAccCredentialType_RemovalDrift
=== RUN   TestAccCredentialType_NewEnv
=== PAUSE TestAccCredentialType_NewEnv
=== RUN   TestAccCredentialType_Full
=== PAUSE TestAccCredentialType_Full
=== RUN   TestAccCredentialType_MetaData
=== PAUSE TestAccCredentialType_MetaData
=== RUN   TestAccCredentialType_CardDesignTemplate
=== PAUSE TestAccCredentialType_CardDesignTemplate
=== RUN   TestAccCredentialType_BadParameters
=== PAUSE TestAccCredentialType_BadParameters
=== CONT  TestAccCredentialType_RemovalDrift
=== CONT  TestAccCredentialType_MetaData
=== CONT  TestAccCredentialType_Full
=== CONT  TestAccCredentialType_BadParameters
=== CONT  TestAccCredentialType_CardDesignTemplate
=== CONT  TestAccCredentialType_NewEnv
--- PASS: TestAccCredentialType_MetaData (0.53s)
--- PASS: TestAccCredentialType_CardDesignTemplate (0.54s)
--- PASS: TestAccCredentialType_NewEnv (5.60s)
--- PASS: TestAccCredentialType_BadParameters (6.08s)
--- PASS: TestAccCredentialType_RemovalDrift (8.66s)
--- PASS: TestAccCredentialType_Full (32.16s)
PASS
ok      github.com/pingidentity/terraform-provider-pingone/internal/service/credentials 32.599s

@mjspi mjspi changed the title SDK update to support the issuance of multiple verifiable credentials… Support the issuance of multiple verifiable credentials based on a directory attribute. Oct 31, 2023
@mjspi mjspi self-assigned this Oct 31, 2023
@mjspi mjspi added the enhancement New feature or request label Oct 31, 2023
@mjspi mjspi marked this pull request as ready for review October 31, 2023 00:35
@patrickcping patrickcping merged commit 64903ae into main Oct 31, 2023
13 checks passed
@patrickcping patrickcping deleted the support-multiple-issuance-properties-on-credential-type branch October 31, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants