forked from paritytech/substrate
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Europa/contracts/enhance error handling #16
Merged
atenjin
merged 45 commits into
europa-contracts
from
europa/contracts/enhance_error_handling
Jan 8, 2021
Merged
Europa/contracts/enhance error handling #16
atenjin
merged 45 commits into
europa-contracts
from
europa/contracts/enhance_error_handling
Jan 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the need to manually store any trap reasons to the `Runtime` from the host function. This adds the following benefits: * It properly composes with the upcoming chain extensions * Missing to set a trap value is now a compile error
The chain extension is a way for the contract author to add new host functions for contracts to call.
Not all offsets where properly updated when changing the fixtures for the new salt on instantiate.
…cting gas function
…e_error_handling # Conflicts: # Cargo.lock # frame/contracts/Cargo.toml # frame/contracts/src/wasm/mod.rs # frame/contracts/src/wasm/runtime.rs
atenjin
force-pushed
the
europa-contracts
branch
from
January 7, 2021 07:04
292f3a1
to
57ac245
Compare
…e_error_handling # Conflicts: # Cargo.lock # frame/contracts/Cargo.toml # frame/contracts/src/exec.rs # frame/contracts/src/tests.rs
…andling # Conflicts: # Cargo.lock # frame/contracts/Cargo.toml # frame/contracts/src/wasm/runtime.rs
atenjin
approved these changes
Jan 8, 2021
link to this issue paritytech#5239 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.