-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT: DO NOT MERGE] Adding electrophys terms #463
base: master
Are you sure you want to change the base?
Conversation
@tgbugs this is the branch, thanks |
id: PATO:0070044 | ||
name: cellular electrophysiological quality | ||
def: "A cellular quality that exists by virtue of the electrical properties of the cell." [WikipediaVersioned:Electrophysiology&oldid=1059385774] | ||
xref: ilxtr:ElectrophysiologicalPhenotype |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ilxtr is not in bioregistry - what is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've taken it straight from the link @tgbugs gave above (https://github.com/SciCrunch/NIF-Ontology/blob/78f17596d18bd3f1139ea33bbb6b112c97f8162f/ttl/phenotypes.ttl#L303) happy to change it to something else
src/ontology/pato-edit.obo
Outdated
|
||
[Term] | ||
id: PATO:0070047 | ||
name: Petilla sustained spiking phenotype |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't normally include the name of the terminology system in the term label, unless really necessary for disambiguation.
Why not just "sustained spiking phenotype"
Also should all Petilla terms not have some kind of provenance to https://www.nature.com/articles/nrn2402
(I realize this is a WIP apologies if this is all part of your plan already)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was hoping provenance would be shown by an xref to that paper in def when that is done. Will also add that xref to the Petilla synonyms.
[INCOMPLETE! DO NOT MERGE YET]
Fixes #462
Structure copied from NLX: https://github.com/SciCrunch/NIF-Ontology/blob/78f17596d18bd3f1139ea33bbb6b112c97f8162f/ttl/phenotypes.ttl#L303
Still requires definitions and contributor to be filled in