Add reciprocal_of in inverse direction. #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drseb
reviewed
Jun 3, 2019
|
Can you explain to me the difference between is_opposite_of and reciprocal_of ? |
|
I don't think reciprocals are opposites. Basically it's just an inversion of the EQ model between
is reciprocal of:
|
cmungall
approved these changes
Jun 5, 2019
|
Adding an approval on this one - will be needed for Phenoscape queries on absence |
|
@nicolevasilevsky could you merge this? |
|
@wdahdul I think you need to officially approve this, it says merging is blocked, Merging can be performed automatically with 2 approving reviews. |
wdahdul
approved these changes
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for querying; can't be inferred at class level.