Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library: add proguard consumer rules #8

Merged
merged 1 commit into from
Nov 18, 2016

Conversation

amartinz
Copy link
Contributor

No description provided.

Change-Id: I71299bdd2c902ebfe5c154d6faa15ee81d87a57f
Signed-off-by: Alexander Martinz <[email protected]>
@amartinz amartinz mentioned this pull request Nov 18, 2016
@codecov-io
Copy link

codecov-io commented Nov 18, 2016

Current coverage is 88.20% (diff: 100%)

Merging #8 into master will not change coverage

@@             master         #8   diff @@
==========================================
  Files            30         30          
  Lines           424        424          
  Methods           0          0          
  Messages          0          0          
  Branches         29         29          
==========================================
  Hits            374        374          
  Misses           41         41          
  Partials          9          9          

Powered by Codecov. Last update 8ba03dc...5646fde

@amartinz
Copy link
Contributor Author

not complete though, Geofencer is still acting up, gradle cached my build and it showed up after clearing the cache and the project.

@patloew
Copy link
Owner

patloew commented Nov 18, 2016

The Geocoder class does not exist anymore. I renamed it to Geocoding before release. I guess some class files were still cached and included in the library. Lesson learned – always do a clean before making a release build 😉 Thanks for the PR.

@patloew patloew merged commit 8ca99db into patloew:master Nov 18, 2016
@amartinz
Copy link
Contributor Author

... and I turned it into Geofencer in comments, so we have 3 variants to choose now :-D

You are welcome, thanks for this library!

@amartinz amartinz deleted the proguard-consumer branch November 18, 2016 19:45
@patloew patloew mentioned this pull request Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants