-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Scala 3 support #573
Conversation
* @see | ||
* [[https://docs.oracle.com/javase/10/docs/api/java/lang/Class.html#getResource(java.lang.String) Class#getResource]] | ||
*/ | ||
def at(clazz: Class[_]): Resource = new Resource { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've not implemented atDymanic(Class)
macro here since passing Class instance happens at run-time and the compile-time macro seems not needed IIUC.
any chance of merging this soon @pathikrit ? 🙏 |
@pathikrit Would be nice if you could also release a new version with the Scala 3 artifacts, thanks! |
@pathikrit Ping 😉 Any chance to release a new version soon with the Scala 3 artifacts? Also there are a lot of PR with dependency upgrades: https://github.com/pathikrit/better-files/pulls |
@pathikrit Would you like more maintainers? I can't afford to get very deeply into the code here, but I can certainly help with reviewing and merging routine PRs, especially for things like dependency upgrades, build improvements, and so forth. Perhaps other volunteers would also be interested. |
Ok I think I finally managed to release v3.9.2 for Scala 3: Please confirm usage! |
Closes #506
Probably it is better to wait until this repo migrates from TravisCI to GitHub Actions in #529
scala-2
directory.better.files.ResourceScalaCompat
and have different implementations inscala-2
andscala-3
since macro mechanism is incompatible.