Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ManagedResource #233

Closed
argv-minus-one opened this issue May 3, 2018 · 0 comments
Closed

Rename ManagedResource #233

argv-minus-one opened this issue May 3, 2018 · 0 comments
Assignees
@pathikrit
Labels
health

Comments

@argv-minus-one
Copy link
Contributor

argv-minus-one commented May 3, 2018 •
edited
Loading

With the recent addition of the Resource object, better-files now has Resource and ManagedResource—which, despite the confusingly similar names, have almost nothing to do with each other.

We can't rename Resource (because that's what Java calls them). So, how about renaming ManagedResource, perhaps to something like AutoDisposed or simply Dispose?
@pathikrit pathikrit self-assigned this May 3, 2018
pathikrit added a commit that referenced this issue May 22, 2018
@pathikrit
Add #233 to 4.0.0 release plan
95b3634
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pathikrit pathikrit

Labels
health
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pathikrit @argv-minus-one