Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the contribution guide #11

Merged
merged 7 commits into from
Nov 22, 2024
Merged

Conversation

patdel0
Copy link
Owner

@patdel0 patdel0 commented Nov 21, 2024

Description

This PR introduces the initial draft of our contribution guide.

The plan is to keep updating it as the project evolves, addressing any
commonly asked questions and providing additional clarification as
needed.

The guide is inspired by the excellent contribution guide from Hack For
LA. It has been heavily simplified to better suit the goal of our
project of making contribution accessible to all, by attempting to not
overwhelm new developers with too much information.

In addition to the guide, a Pull Request template was added to streamline
the creation process.

Closes #4

Type of change

  • This change requires a documentation update

This commit introduces the initial draft of our contribution guide.

The plan is to keep updating it as the project evolves, addressing any
commonly asked questions and providing additional clarification as
needed.

The guide is inspired by the excellent contribution guide from Hack For
LA. It has been heavily simplified to better suit the goals of our
project of accessibility, by attempting to not overwhelm new developers
with too much information.
@patdel0 patdel0 linked an issue Nov 21, 2024 that may be closed by this pull request
Copy link
Collaborator

@matthiasjrichter matthiasjrichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding work!


**For example:** `https://github.com/octocat/SAGP`.

**Be Aware:** What you have created is a forked copy in a remote version on GitHub. It is not on your local machine yet.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For newer developers and for convenience, add a link on how to clone a repository. The official docs should be sufficient: https://docs.github.com/en/repositories/creating-and-managing-repositories/cloning-a-repository

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! I'll add a section for that

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion. I added it under commit 4a0fc8a.

Before, there were only general guidelines and a brief intro into what a
Code Review is.
Now, detailed instructions with images were added for reviewers.
Copy link
Collaborator

@matthiasjrichter matthiasjrichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@matthiasjrichter matthiasjrichter merged commit 7b9d3ae into main Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write contribution guide
2 participants