Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed status #664

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Failed status #664

merged 1 commit into from
Dec 30, 2024

Conversation

DavidBadura
Copy link
Member

@DavidBadura DavidBadura commented Dec 30, 2024

Add another status called "Failed". This status is reached when the retry strategy says not to retry or not to make another attempt. This prevents the subscription from being checked in every run and dragging down performance. If the retry strategy max attempt is set to infinity, then the failed status is never reached.

@DavidBadura DavidBadura added this to the 3.7.0 milestone Dec 30, 2024
@DavidBadura DavidBadura added the enhancement New feature or request label Dec 30, 2024
@DavidBadura DavidBadura force-pushed the failed-status branch 2 times, most recently from c7b229f to 7ab1094 Compare December 30, 2024 12:43
Copy link

github-actions bot commented Dec 30, 2024

Hello 👋

here is the most recent benchmark result:

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 996.300μs (±0.00%) | 1.006ms (±0.00%)   | -0.92%    | 34.266mb        | 34.274mb   | -0.02%      |
| benchLoad10000Events ()                | 47.865ms (±0.00%)  | 50.737ms (±0.00%)  | -5.66%    | 34.266mb        | 34.274mb   | -0.02%      |
| benchSave1Event ()                     | 1.031ms (±0.00%)   | 1.024ms (±0.00%)   | +0.69%    | 33.765mb        | 33.765mb   | 0.00%       |
| benchSave10000Events ()                | 216.015ms (±0.00%) | 227.768ms (±0.00%) | -5.16%    | 33.765mb        | 33.765mb   | 0.00%       |
| benchSave10000Aggregates ()            | 9.388s (±0.00%)    | 9.378s (±0.00%)    | +0.11%    | 33.765mb        | 33.765mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 4.879s (±0.00%)    | 4.893s (±0.00%)    | -0.27%    | 33.765mb        | 33.765mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 47.903ms (±0.00%)  | 48.978ms (±0.00%)  | -2.19%    | 33.836mb        | 33.836mb   | 0.00%       |
| benchLoad10000Events ()                | 905.200μs (±0.00%) | 897.200μs (±0.00%) | +0.89%    | 33.836mb        | 33.836mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBatchBench
============================

+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                   | memory                                     |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 72.310ms (±0.00%) | 74.327ms (±0.00%) | -2.71%    | 34.234mb        | 34.234mb   | 0.00%       |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.162s (±0.00%) | 3.194s (±0.00%) | -0.98%    | 46.382mb        | 46.382mb   | 0.00%       |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 944.500μs (±0.00%) | 947.900μs (±0.00%) | -0.36%    | 34.895mb        | 34.895mb   | 0.00%       |
| benchLoad10000Events ()                | 87.740ms (±0.00%)  | 84.733ms (±0.00%)  | +3.55%    | 34.895mb        | 34.895mb   | 0.00%       |
| benchSave1Event ()                     | 1.596ms (±0.00%)   | 1.606ms (±0.00%)   | -0.63%    | 34.895mb        | 34.895mb   | 0.00%       |
| benchSave10000Events ()                | 250.950ms (±0.00%) | 249.853ms (±0.00%) | +0.44%    | 34.897mb        | 34.897mb   | 0.00%       |
| benchSave10000Aggregates ()            | 12.888s (±0.00%)   | 12.962s (±0.00%)   | -0.57%    | 34.895mb        | 34.895mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 9.112s (±0.00%)    | 9.097s (±0.00%)    | +0.17%    | 35.396mb        | 35.396mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 941.700μs (±0.00%) | 964.300μs (±0.00%) | -2.34%    | 34.862mb        | 34.862mb   | 0.00%       |
| benchLoad10000Events ()                | 57.002ms (±0.00%)  | 57.280ms (±0.00%)  | -0.49%    | 34.862mb        | 34.862mb   | 0.00%       |
| benchSave1Event ()                     | 972.500μs (±0.00%) | 1.119ms (±0.00%)   | -13.05%   | 34.862mb        | 34.862mb   | 0.00%       |
| benchSave10000Events ()                | 309.855ms (±0.00%) | 302.315ms (±0.00%) | +2.49%    | 34.862mb        | 34.862mb   | 0.00%       |
| benchSave10000Aggregates ()            | 8.676s (±0.00%)    | 9.658s (±0.00%)    | -10.17%   | 34.862mb        | 34.862mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 5.179s (±0.00%)    | 5.123s (±0.00%)    | +1.09%    | 34.862mb        | 34.862mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 4.334ms (±0.00%)   | 4.265ms (±0.00%)   | +1.63%    | 37.072mb        | 37.072mb   | 0.00%       |
| benchSave10000Events () | 348.011ms (±0.00%) | 340.882ms (±0.00%) | +2.09%    | 37.145mb        | 37.144mb   | +0.00%      |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura force-pushed the failed-status branch 2 times, most recently from 668e6db to 3bde149 Compare December 30, 2024 14:05
docs/pages/subscription.md Outdated Show resolved Hide resolved
docs/pages/subscription.md Outdated Show resolved Hide resolved
@DavidBadura DavidBadura merged commit 190b88b into 3.7.x Dec 30, 2024
39 of 40 checks passed
@DavidBadura DavidBadura deleted the failed-status branch December 30, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants